Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ts): Update webpack to include babel-loader in tandem with ts-loader #14226

Merged
merged 2 commits into from Aug 2, 2019

Conversation

dashed
Copy link
Member

@dashed dashed commented Jul 31, 2019

This alleviates this error occurring at runtime:

Error: Component selectors can only be used in conjunction with babel-plugin-emotion.

TODO


Some hints from emotion-js/emotion#535

@dashed dashed requested a review from a team July 31, 2019 12:41
@dashed dashed self-assigned this Jul 31, 2019
Copy link
Member

@lynnagara lynnagara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this. I wonder if there is any impact on compilation time.

@dashed
Copy link
Member Author

dashed commented Jul 31, 2019

@lynnagara
Copy link
Member

lynnagara commented Jul 31, 2019 via email

@dashed
Copy link
Member Author

dashed commented Jul 31, 2019

Yea we'll probably need it in getsentry as well.

@dashed
Copy link
Member Author

dashed commented Aug 1, 2019

@dashed
Copy link
Member Author

dashed commented Aug 2, 2019

I'll open a PR for a similar webpack change for getsentry/getsentry later today.

@dashed dashed merged commit c5304e3 into master Aug 2, 2019
@dashed dashed deleted the typescript/update-webpack branch August 2, 2019 20:12
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants