Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Upgrade jest to 23.6.0 #11409

Merged
merged 1 commit into from Jan 8, 2019
Merged

chore: Upgrade jest to 23.6.0 #11409

merged 1 commit into from Jan 8, 2019

Conversation

evanpurkhiser
Copy link
Member

The failed tests that had to be fixed relate to jestjs/jest#6792

@evanpurkhiser
chore: Upgrade jest to 23.6.0
a0031e2 
The failed tests that had to be fixed relate to jestjs/jest#6792
@evanpurkhiser evanpurkhiser requested a review from a team January 8, 2019 01:44
billyvg
billyvg approved these changes Jan 8, 2019
View reviewed changes
Copy link
Member

@billyvg billyvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. In the future can you link to changelog and/or add some notes about what the upgrade gives us?

@evanpurkhiser evanpurkhiser merged commit 2f79b6f into master Jan 8, 2019
@evanpurkhiser evanpurkhiser deleted the chore-upgrade-jest-to-2360 branch January 8, 2019 02:13
@evanpurkhiser
Copy link
Member Author

evanpurkhiser commented Jan 8, 2019 •
edited

Sure.

I specifically wanted this to support the babel.config.js file, jestjs/jest#6911

Which landed in 23.6.0: https://github.com/facebook/jest/blob/master/CHANGELOG.md#features-1

@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@billyvg billyvg billyvg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@evanpurkhiser @billyvg