Skip to content

Commit

Permalink
ui(quick-trace): Placeholder should be smaller (#24823)
Browse files Browse the repository at this point in the history
Quick trace only takes up 24px vertically now that the alignment has been fixed.
This adjusts the placeholder to the appropriate size to remove layout shifts
once quick trace loads.
  • Loading branch information
Zylphrex committed Mar 30, 2021
1 parent 72280bf commit d2e156b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Expand Up @@ -74,7 +74,7 @@ class GroupEventToolbar extends React.Component<Props> {
<QuickTraceQuery event={event} location={location} orgSlug={organization.slug}>
{results =>
results.isLoading ? (
<Placeholder height="27px" />
<Placeholder height="24px" />
) : results.error || results.trace === null ? (
'\u2014'
) : (
Expand Down
Expand Up @@ -46,7 +46,7 @@ export default function QuickTraceMeta({
const traceTarget = generateTraceTarget(event, organization);

const body = isLoading ? (
<Placeholder height="27px" />
<Placeholder height="24px" />
) : error || trace === null ? (
'\u2014'
) : (
Expand Down

0 comments on commit d2e156b

Please sign in to comment.