Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix TraceableResponseForV4::getInfo to be compatible with symfony-contracts in symfony-sentry 5.0.0 #835

Closed
wants to merge 1 commit into from

Conversation

jeslopcru
Copy link

Hi!
I found this issue #834 about a wrong signature in method getInfo
on Sentry\SentryBundle\Tracing\HttpClient\TraceableResponseForV4 using version 5.0.0.

Here you can see the change to make compatible the method.

I hope that it will help, let me know if you need any update

Copy link
Collaborator

@Jean85 Jean85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approved the CI just to show how this change is not feasible: this bundle supports back to PHP 7.2, so mixed is not allowed.

Thanks to PHP 7.2 having partial type widening though, this is perfectly valid code.

@Jean85
Copy link
Collaborator

Jean85 commented Apr 16, 2024

Thanks for the contribution anyway.

@Jean85 Jean85 closed this Apr 16, 2024
@jeslopcru
Copy link
Author

jeslopcru commented Apr 16, 2024

Thanks for the explanation! I will figure out how to fix my code to avoid this issue

Edited:
Brief explanation about what was wrong in my project in the issue

@jeslopcru jeslopcru deleted the fix-symfony-contracts branch April 17, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants