Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos/changelog #304

Merged
merged 4 commits into from Jan 21, 2020
Merged

Fix typos/changelog #304

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3620354
Fix typos in changelog
guilliamxavier Jan 20, 2020
c4e140f
Fix typo in test
guilliamxavier Jan 20, 2020
6b92458
Fix changelog: 3.4.0 has not been released yet
guilliamxavier Jan 20, 2020
0a970b0
Update 3.4.0 release date
guilliamxavier Jan 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions CHANGELOG.md
View file
Open in desktop
Expand Up @@ -6,12 +6,12 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.

## Unreleased
- ...
## 3.4.0 (2020-01-17)

## 3.4.0 (TBA)
guilliamxavier marked this conversation as resolved.
Show resolved Hide resolved
- Add support for `sentry/sentry` 2.3 (#298)
- Drop support for `sentry/sentry` < 2.3 (#298)
- Add support to `in_app_include` client option (#298)
- Remap `excluded_exception` option to use the new `IgnoreErrorIntegration` (#298)
- Remap `excluded_exceptions` option to use the new `IgnoreErrorsIntegration` (#298)

## 3.3.2 (2020-01-16)
- Fix issue with exception listener under Symfony 4.3 (#301)
Expand Down
2 changes: 1 addition & 1 deletion test/DependencyInjection/SentryExtensionTest.php
View file
Open in desktop
Expand Up @@ -41,7 +41,7 @@ public function testDataProviderIsMappingTheRightNumberOfOptions(): void

// subtracted one is `integration`, which cannot be tested with the provider
$expectedCount = $this->getSupportedOptionsCount();
--$expectedCount; // excluded_exceptions is remapped to the new IgnoreErrorIntegration
--$expectedCount; // excluded_exceptions is remapped to the new IgnoreErrorsIntegration

if (PrettyVersions::getVersion('sentry/sentry')->getPrettyVersion() === '2.0.0') {
--$expectedCount;
Expand Down