Exception listener with dedicated data methods

[bouland]

Sorry for my PR #176, i used version 2.0.2 and didn't take last changes.

Issue #175

[Jean85]

I'm sorry but I think I've missed those too... Where did you got those changes? They aren't from this bundle, it seems. Maybe from a fork?

[bouland]

I'm sorry but I think I've missed those too... Where did you got those changes? They aren't from this bundle, it seems. Maybe from a fork?

No fork, just folowing PR

• PR 167
• PR 139

[bouland]

My goal is to write this overriding code

class SentryExceptionListener extends ExceptionListener
{
    /**
     * @param object|string|UserInterface|SentryUserInterface $user
     */
    protected function setUserValue($user)
    {
        if (!$user instanceof SentryUserInterface) {
            parent::setUserValue($user);
            return;
        }

        $this->client->set_user_data(
            $user->getId(),
            $user->getEmail(),
            parent::getUserData() + $user->getSentryData()
        );
    }
}

[bouland]

UP !

What do you think about it ?

[Jean85]

Those are breaking changes for anyone that is extending the listener like you, so I cannot merge this as is.

[tlesne]

I don't get how the changes are breaking the current behaviour that may be expected from other users extending the listener.
The code just seems refactored in sub function and not breaking the methods signature.

[Jean85]

You're right, the diff here on GitHub tricked me, you just wrapped stuff without breaking changes.

LGTM then! 👍