Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PHPStan build #162

Merged
merged 2 commits into from Oct 29, 2018
Merged

Fix PHPStan build #162

merged 2 commits into from Oct 29, 2018

Conversation

Jean85
Copy link
Collaborator

@Jean85 Jean85 commented Oct 29, 2018

As found in #161, we need to fix the build for PHPStan.

@Jean85 Jean85 self-assigned this Oct 29, 2018
stayallive
stayallive reviewed Oct 29, 2018
View reviewed changes
Copy link
Collaborator

@stayallive stayallive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Jean85
Copy link
Collaborator Author

Jean85 commented Oct 29, 2018

Ping @HazAT, I need a review here... alternatively, who should I bother about this stuff in general?

stayallive
stayallive approved these changes Oct 29, 2018
View reviewed changes
Copy link
Collaborator

@stayallive stayallive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought I approved this already...?

@Jean85 Jean85 merged commit b44ab83 into master Oct 29, 2018
@Jean85 Jean85 deleted the fix-phpstan-build branch October 29, 2018 16:57
@Jean85
Copy link
Collaborator Author

Jean85 commented Oct 29, 2018

Thanks @stayallive! Nope, you just added a "comment" review, not an "approved" one...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stayallive stayallive stayallive approved these changes

Assignees

@Jean85 Jean85

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Jean85 @stayallive