Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix processorOptions configuration (1.x) #109

Merged
merged 2 commits into from Feb 28, 2018
Merged

Fix processorOptions configuration (1.x) #109

merged 2 commits into from Feb 28, 2018

Conversation

agentsib
Copy link
Contributor

#107 PR for branch release/1.x

@Jean85
Copy link
Collaborator

Jean85 commented Feb 26, 2018

Thank you for porting this! It seems that the build is failing on older Symfony versions: https://travis-ci.org/getsentry/sentry-symfony/jobs/346355368#L690

Is arrayPrototype a method declared only from 3.x onward?

@agentsib
Copy link
Contributor Author

agentsib commented Feb 26, 2018 •
edited

@Jean85, yes, this method declared in 3.x. For compatibility with 2.x need replace arrayPrototype to prototype('array'). I can re-open old PR (#107) and apply fix to. But for 3.x it is not necessary.

@agentsib
Copy link
Contributor Author

@Jean85 build is failed due to the composer :(

Jean85
Jean85 approved these changes Feb 26, 2018
View reviewed changes
Copy link
Collaborator

@Jean85 Jean85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's perfect, thanks! I'll try to restart the build to get that green!

@Jean85 Jean85 merged commit efa47c1 into getsentry:releases/1.x Feb 28, 2018
@Jean85
Copy link
Collaborator

Jean85 commented Mar 7, 2018

Released as 1.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jean85 Jean85 Jean85 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@agentsib @Jean85