Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid double-reporting of CLI errors #105

Merged
merged 2 commits into from Jan 31, 2018
Merged

Avoid double-reporting of CLI errors #105

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
935fd6e
Avoid double-reporting of CLI errors
Jean85 Jan 31, 2018
0d72d42
Release 2.0.1 patch
Jean85 Jan 31, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Expand Up @@ -6,6 +6,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.

## [Unreleased]

## 2.0.1 - TBA
### Fixed
- Avoid reporting CLI errors twice (#104)

## 2.0.0 - 2017-12-12
### Added
- Add support for Symfony 4.x
Expand Down
1 change: 0 additions & 1 deletion src/Resources/config/services.yml
View file
Open in desktop
Expand Up @@ -18,5 +18,4 @@ services:
- { name: kernel.event_listener, event: kernel.request, method: onKernelRequest, priority: '%sentry.listener_priorities.request%'}
- { name: kernel.event_listener, event: kernel.exception, method: onKernelException, priority: '%sentry.listener_priorities.kernel_exception%' }
- { name: kernel.event_listener, event: console.command, method: onConsoleCommand }
- { name: kernel.event_listener, event: console.exception, method: onConsoleException, priority: '%sentry.listener_priorities.console_exception%' }
- { name: kernel.event_listener, event: console.error, method: onConsoleError, priority: '%sentry.listener_priorities.console_exception%' }
5 changes: 0 additions & 5 deletions test/DependencyInjection/SentryExtensionTest.php
View file
Open in desktop
Expand Up @@ -287,11 +287,6 @@ public function test_that_it_has_proper_event_listener_tags_for_exception_listen
'priority' => '%sentry.listener_priorities.kernel_exception%',
],
['event' => 'console.command', 'method' => 'onConsoleCommand'],
[
'event' => 'console.exception',
'method' => 'onConsoleException',
'priority' => '%sentry.listener_priorities.console_exception%',
],
[
'event' => 'console.error',
'method' => 'onConsoleError',
Expand Down