Drop Symfony support below 4.4 #643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ste93cry
requested changes
Jun 23, 2022
ste93cry
requested changes
Jun 25, 2022
There was a problem hiding this comment.
There are still things to delete: in the SubRequestListenerTest class some of the data providers are still splitted per-Symfony version, and probably we can also remove the KernelEventForwardCompatibilityTrait trait. I suggest to look for occurences of the version_compare or Kernel::VERSION keywords
|
I took care of the rest. |
ste93cry
approved these changes
Jun 28, 2022
alekitto
pushed a commit
to alekitto/sentry-symfony
that referenced
this pull request
Jul 5, 2022
This was referenced Oct 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm opening this as a draft since it may require some discussion (or dropping some pieces of code no longer used).3.4 is unsupported since last November: https://symfony.com/releases/3.4
Everything between that and 4.4 (since it's an LTS) is unsupported too.
Hence, dropping the support now makes sense. This PR is targeting
develop, so it would land in the next minor (4.4 as of now).