Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump minimum required version of the core SDK to 3.9 #15

Merged
merged 1 commit into from Oct 11, 2022

Conversation

cleptric
Copy link
Member

This is needed to support DS in the Symfony SDK.

@stayallive
Copy link
Collaborator

stayallive commented Oct 10, 2022

Shouldn't Symfony require sentry/sentry with it's own constraint instead of bumping the SDK just for Symfony (like we do in Laravel) 😅 (obviously this is also fine but could be simpler?)

Edit: Which you also did: getsentry/sentry-symfony#661 (comment). Why shouldn't we keep that constraint at the Symfony side? Wouldn't that make it simpler and we can just release a sentry/sdk when we really need people to upgrade or when we release a major version.

@cleptric
Copy link
Member Author

We can continue the discussion over at getsentry/sentry-symfony#643. I don't see why we shouldn't do the same as in the Laravel SDK either.

@cleptric cleptric merged commit d0678fc into master Oct 11, 2022
@cleptric cleptric deleted the bump-min-core-version branch October 11, 2022 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants