Skip to content

Commit

Permalink
Merge pull request #181 from jvasseur/remove-server-name-default
Browse files Browse the repository at this point in the history
Remove server_name default value
  • Loading branch information
Jean85 committed Jan 9, 2019
2 parents 353f9d3 + 74833d9 commit a4054b4
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
3 changes: 1 addition & 2 deletions src/DependencyInjection/Configuration.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

namespace Sentry\SentryBundle\DependencyInjection;

use Raven_Compat;
use Sentry\SentryBundle\EventListener\ExceptionListener;
use Sentry\SentryBundle\EventListener\SentryExceptionListenerInterface;
use Sentry\SentryBundle\SentrySymfonyClient;
Expand Down Expand Up @@ -58,7 +57,7 @@ public function getConfigTreeBuilder()
->scalarNode('public_key')->defaultNull()->end()
->scalarNode('project')->defaultValue(1)->end()
->booleanNode('auto_log_stacks')->defaultFalse()->end()
->scalarNode('name')->defaultValue(Raven_Compat::gethostname())->end()
->scalarNode('name')->defaultNull()->end()
->scalarNode('site')->defaultNull()->end()
->arrayNode('tags')
->prototype('scalar')->end()
Expand Down
2 changes: 1 addition & 1 deletion test/DependencyInjection/SentryExtensionTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ public function test_that_configuration_uses_the_right_default_values()
$this->assertNull($options['public_key']);
$this->assertSame(1, $options['project']);
$this->assertFalse($options['auto_log_stacks']);
$this->assertSame(\Raven_Compat::gethostname(), $options['name']);
$this->assertNull($options['name']);
$this->assertNull($options['site']);
$this->assertSame([], $options['tags']);
$this->assertNull($options['release']);
Expand Down

0 comments on commit a4054b4

Please sign in to comment.