fix static analysis

getsentry · Jul 11, 2022 · 6ebbb8a · 6ebbb8a
1 parent 27d9d53
commit 6ebbb8a
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 5 deletions.
diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon
@@ -280,11 +280,6 @@ parameters:
 			count: 1
 			path: src/Tracing/HttpClient/AbstractTraceableResponse.php
 
-		-
-			message: "#^Method Sentry\\\\SentryBundle\\\\Tracing\\\\HttpClient\\\\AbstractTraceableResponse::stream\\(\\) has parameter \\$responses with no value type specified in iterable type iterable.$#"
-			count: 1
-			path: src/Tracing/HttpClient/AbstractTraceableResponse.php
-
 		-
 			message: "#^Method Sentry\\\\SentryBundle\\\\Tracing\\\\HttpClient\\\\TraceableHttpClientForV6::withOptions\\(\\) has parameter \\$options with no value type specified in iterable type array.$#"
 			count: 1

diff --git a/src/Tracing/HttpClient/AbstractTraceableHttpClient.php b/src/Tracing/HttpClient/AbstractTraceableHttpClient.php
@@ -67,6 +67,8 @@ public function request(string $method, string $url, array $options = []): Respo
 
     /**
      * {@inheritdoc}
+     *
+     * @param AbstractTraceableResponse|iterable<AbstractTraceableResponse> $responses
      */
     public function stream($responses, float $timeout = null): ResponseStreamInterface
     {

diff --git a/tests/Tracing/HttpClient/TraceableHttpClientTest.php b/tests/Tracing/HttpClient/TraceableHttpClientTest.php
@@ -87,6 +87,7 @@ public function testRequest(): void
 
         $response->getContent(false);
 
+        $this->assertNotNull($transaction->getSpanRecorder());
         $spans = $transaction->getSpanRecorder()->getSpans();
         $this->assertCount(2, $spans);
         $this->assertNotNull($spans[1]->getEndTimestamp());