Fix error raised by PHPStan

getsentry · Oct 29, 2018 · 6693f56 · 6693f56
1 parent 7c76ba5
commit 6693f56
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/src/ErrorTypesParser.php b/src/ErrorTypesParser.php
@@ -55,6 +55,10 @@ private function convertErrorConstants(string $expression): string
             return $errorConstant[0];
         }, $expression);
 
+        if (null === $output) {
+            throw new \InvalidArgumentException('Unable to parse error types string: ' . $expression);
+        }
+
         return $output;
     }
 

diff --git a/test/ErrorTypesParserTest.php b/test/ErrorTypesParserTest.php
@@ -20,4 +20,12 @@ public function test_error_types_parser_throws_exception_for_unwanted_values()
         $this->expectException(\InvalidArgumentException::class);
         $ex->parse();
     }
+
+    public function test_error_types_parser_throws_exception_for_unparsable_values()
+    {
+        $ex = new ErrorTypesParser('something-wrong');
+
+        $this->expectException(\InvalidArgumentException::class);
+        $ex->parse();
+    }
 }