Skip to content

Add support for doctrine/dbal v4.0 #1095

Add support for doctrine/dbal v4.0

Add support for doctrine/dbal v4.0 #1095

Triggered via pull request February 26, 2024 05:56
@cleptriccleptric
synchronize #811
dbal-4
Status Failure
Total duration 38s
Artifacts

static-analysis.yaml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

8 errors and 3 warnings
PHPStan: src/Tracing/Doctrine/DBAL/TracingDriverConnectionForV4.php#L123
Method Sentry\SentryBundle\Tracing\Doctrine\DBAL\TracingDriverConnectionForV4::exec() should return int|numeric-string but returns int|string.
PHPStan: tests/Tracing/Doctrine/DBAL/TracingDriverConnectionFactoryV4Test.php#L31
Property Sentry\SentryBundle\Tests\Tracing\Doctrine\DBAL\TracingDriverConnectionFactoryV4Test::$databasePlatform is never read, only written.
PHPStan: tests/Tracing/Doctrine/DBAL/TracingDriverMiddlewareTest.php#L31
Parameter #1 $hubOrConnectionFactory of class Sentry\SentryBundle\Tracing\Doctrine\DBAL\TracingDriverMiddleware constructor expects Sentry\SentryBundle\Tracing\Doctrine\DBAL\TracingDriverConnectionFactoryInterface|Sentry\State\HubInterface, null given.
PHPStan
Process completed with exit code 1.
TooManyArguments: src/Tracing/Doctrine/DBAL/TracingDriverForV4.php#L35
src/Tracing/Doctrine/DBAL/TracingDriverForV4.php:35:9: TooManyArguments: Too many arguments for Doctrine\DBAL\Driver\Middleware\AbstractDriverMiddleware::__construct - expecting 0 but saw 1 (see https://psalm.dev/026)
MoreSpecificImplementedParamType: src/Tracing/Doctrine/DBAL/TracingDriverForV4.php#L45
src/Tracing/Doctrine/DBAL/TracingDriverForV4.php:45:35: MoreSpecificImplementedParamType: Argument 1 of Sentry\SentryBundle\Tracing\Doctrine\DBAL\TracingDriverForV4::connect has the more specific type 'array{application_name?: string, charset?: string, dbname?: string, defaultTableOptions?: array<string, mixed>, driver?: 'ibm_db2'|'mysqli'|'oci8'|'pdo_mysql'|'pdo_oci'|'pdo_pgsql'|'pdo_sqlite'|'pdo_sqlsrv'|'pgsql'|'sqlite3'|'sqlsrv', driverClass?: class-string<Doctrine\DBAL\Driver>, driverOptions?: array<array-key, mixed>, host?: string, keepReplica?: bool, memory?: bool, password?: string, path?: string, persistent?: bool, port?: int, primary?: array{application_name?: string, charset?: string, dbname?: string, defaultTableOptions?: array<string, mixed>, driver?: 'ibm_db2'|'mysqli'|'oci8'|'pdo_mysql'|'pdo_oci'|'pdo_pgsql'|'pdo_sqlite'|'pdo_sqlsrv'|'pgsql'|'sqlite3'|'sqlsrv', driverClass?: class-string<Doctrine\DBAL\Driver>, driverOptions?: array<array-key, mixed>, host?: string, memory?: bool, password?: string, path?: string, persistent?: bool, port?: int, serverVersion?: string, sessionMode?: int, unix_socket?: string, user?: string, wrapperClass?: class-string<Doctrine\DBAL\Connection>}, replica?: array<array-key, array{application_name?: string, charset?: string, dbname?: string, defaultTableOptions?: array<string, mixed>, driver?: 'ibm_db2'|'mysqli'|'oci8'|'pdo_mysql'|'pdo_oci'|'pdo_pgsql'|'pdo_sqlite'|'pdo_sqlsrv'|'pgsql'|'sqlite3'|'sqlsrv', driverClass?: class-string<Doctrine\DBAL\Driver>, driverOptions?: array<array-key, mixed>, host?: string, memory?: bool, password?: string, path?: string, persistent?: bool, port?: int, serverVersion?: string, sessionMode?: int, unix_socket?: string, user?: string, wrapperClass?: class-string<Doctrine\DBAL\Connection>}>, serverVersion?: string, sessionMode?: int, unix_socket?: string, user?: string, wrapperClass?: class-string<Doctrine\DBAL\Connection>}', expecting 'array<array-key, mixed>' as defined by Doctrine\DBAL\Driver\Middleware\AbstractDriverMiddleware::connect (see https://psalm.dev/140)
TooManyArguments: src/Tracing/Doctrine/DBAL/TracingDriverForV4.php#L48
src/Tracing/Doctrine/DBAL/TracingDriverForV4.php:48:28: TooManyArguments: Too many arguments for Doctrine\DBAL\Connection\StaticServerVersionProvider::__construct - expecting 0 but saw 1 (see https://psalm.dev/026)
Psalm
Process completed with exit code 2.
PHPStan
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Psalm
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
PHP-CS-Fixer
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.