ref: Add small improvements to bash scripts (#495)

This makes it a bit easier to read and also we do not have to call external utils to make a change in the variable.
getsentry · Aug 29, 2022 · 4178868 · 4178868
1 parent c335da4
commit 4178868
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/scripts/bump-version.sh b/scripts/bump-version.sh
@@ -2,7 +2,7 @@
 set -euo pipefail
 
 SCRIPT_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
-cd $SCRIPT_DIR/..
+cd "$SCRIPT_DIR"/..
 
 OLD_VERSION="${1}"
 NEW_VERSION="${2}"
@@ -13,4 +13,4 @@ echo "Bumping version: ${NEW_VERSION}"
 perl -pi -e "s/^version = \".*?\"/version = \"$NEW_VERSION\"/" sentry*/Cargo.toml
 perl -pi -e "s/^(sentry.*)?version = \".*?\"/\$1version = \"$NEW_VERSION\"/" sentry*/Cargo.toml
 
-$SCRIPT_DIR/update-readme.sh $NEW_VERSION
+"$SCRIPT_DIR"/update-readme.sh "$NEW_VERSION"
diff --git a/scripts/generate-readme.sh b/scripts/generate-readme.sh
@@ -2,8 +2,8 @@
 set -euo pipefail
 
 NEW_VERSION="${1}"
-CRATE=$(basename $PWD)
-CRATE_UNDERSCORE=$(echo $CRATE | sed s/-/_/)
+CRATE=$(basename "$PWD")
+CRATE_UNDERSCORE="${CRATE//-/_}"
 
 cargo readme --template ../README.tpl --output README.md
 

diff --git a/scripts/update-readme.sh b/scripts/update-readme.sh
@@ -2,8 +2,8 @@
 set -euo pipefail
 
 SCRIPT_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
-cd $SCRIPT_DIR/..
+cd "$SCRIPT_DIR"/..
 
 NEW_VERSION="${1}"
 
-find sentry* -name Cargo.toml -execdir ../scripts/generate-readme.sh $NEW_VERSION \;
+find sentry* -name Cargo.toml -execdir ../scripts/generate-readme.sh "$NEW_VERSION" \;