Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump faraday version to latest #946

Merged
merged 1 commit into from Jan 29, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 0 additions & 5 deletions .travis.yml
Expand Up @@ -10,7 +10,6 @@ branches:
only: [master]

rvm:
- 2.2.10
- 2.3.8
- 2.4.9
- 2.5.7
Expand All @@ -33,10 +32,6 @@ before_install:

matrix:
include:
- rvm: 1.9
env: RAILS_VERSION=4
- rvm: jruby-1.7.27
env: JRUBY_OPTS="--dev" RAILS_VERSION=4
- rvm: jruby-9.2.9.0
env: JRUBY_OPTS="--dev -J-Djruby.launch.inproc=true -J-Xmx1024M" RAILS_VERSION=4
- rvm: jruby-9.2.9.0
Expand Down
2 changes: 1 addition & 1 deletion sentry-raven.gemspec
Expand Up @@ -17,5 +17,5 @@ Gem::Specification.new do |gem|
gem.bindir = "exe"
gem.executables = "raven"

gem.add_dependency "faraday", ">= 0.7.6", "< 1.0"
gem.add_dependency "faraday", ">= 1.0"
end
4 changes: 2 additions & 2 deletions spec/raven/integration_spec.rb
Expand Up @@ -43,15 +43,15 @@
# end

it "timed backoff should prevent sends" do
expect(@instance.client.transport).to receive(:send_event).exactly(1).times.and_raise(Faraday::Error::ConnectionFailed, "conn failed")
expect(@instance.client.transport).to receive(:send_event).exactly(1).times.and_raise(Faraday::ConnectionFailed, "conn failed")
2.times { @instance.capture_exception(build_exception) }
expect(@io.string).to match(/Failed to submit event: ZeroDivisionError: divided by 0$/)
end

it "transport failure should call transport_failure_callback" do
@instance.configuration.transport_failure_callback = proc { |_e| @io.puts "OK!" }

expect(@instance.client.transport).to receive(:send_event).exactly(1).times.and_raise(Faraday::Error::ConnectionFailed, "conn failed")
expect(@instance.client.transport).to receive(:send_event).exactly(1).times.and_raise(Faraday::ConnectionFailed, "conn failed")
@instance.capture_exception(build_exception)
expect(@io.string).to match(/OK!$/)
end
Expand Down