Cleanup Rack interface #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nateberkopec
force-pushed
the
cleanup-rack
branch
from
15d7f74
to
1f398fb
Compare
matthewd
reviewed
Jan 25, 2017
| # env['SERVER_PROTOCOL']. But we don't want to ignore a valid header | ||
| # if the request has legitimately sent a Version header themselves. | ||
| # See: https://github.com/rack/rack/blob/028438f/lib/rack/handler/cgi.rb#L29 | ||
| next if key == 'HTTP_VERSION' && value == ENV['SERVER_PROTOCOL'] |
There was a problem hiding this comment.
@nateberkopec should this be env_hash?
There was a problem hiding this comment.
Whoops! It absolutely should be. Looks like my editor autocorrected 'env' to ENV. Writing a test and fixing.
Since you're here, can you weigh in on rack/rack#970, which is the reason this hack exists?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.