Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure isolated envelopes respect enabled_environments #2291

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

sl0thentr0py
Copy link
Member

Envelopes for metrics/sessions and so on were queued directly before and thus did not respect the config. This introduces a dedicated capture_envelope on the client to centralize these checks.

Closes #2287

Envelopes for metrics/sessions and so on were queued directly before and
thus did not respect the config. This introduces a dedicated
`capture_envelope` on the client to centralize these checks.

Closes #2287
@sl0thentr0py sl0thentr0py marked this pull request as ready for review April 9, 2024 13:01
@sl0thentr0py sl0thentr0py requested a review from st0012 April 9, 2024 13:01
Comment on lines +207 to +208
# note that we don't record client reports for direct envelope types
# such as metrics, sessions etc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do have data categories for both sessions and metrics, though.

@sl0thentr0py sl0thentr0py merged commit aa2e2e6 into master Apr 9, 2024
123 checks passed
@sl0thentr0py sl0thentr0py deleted the neel/enabled-env-metrics branch April 9, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make sure enabled_environments is respected everywhere
2 participants