Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop async configuration #1894

Merged
merged 5 commits into from Apr 26, 2024
Merged

Drop async configuration #1894

merged 5 commits into from Apr 26, 2024

Conversation

st0012
Copy link
Collaborator

@st0012 st0012 commented Sep 15, 2022

Closes #1522

@st0012 st0012 added this to the 6.0.0 milestone Sep 15, 2022
@st0012 st0012 self-assigned this Sep 15, 2022
@st0012 st0012 added this to In progress in 5.x via automation Sep 15, 2022
@github-actions
Copy link

github-actions bot commented Oct 7, 2022

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@codecov
Copy link

codecov bot commented Feb 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.68%. Comparing base (07aaf5e) to head (9df626a).

Additional details and impacted files
@@             Coverage Diff             @@
##           6.0-dev    #1894      +/-   ##
===========================================
- Coverage    98.71%   98.68%   -0.03%     
===========================================
  Files          202      201       -1     
  Lines        13294    13092     -202     
===========================================
- Hits         13123    12920     -203     
- Misses         171      172       +1     
Components Coverage Δ
sentry-ruby 99.07% <100.00%> (-0.03%) ⬇️
sentry-rails 97.26% <100.00%> (-0.12%) ⬇️
sentry-sidekiq 96.98% <ø> (ø)
sentry-resque 96.76% <ø> (ø)
sentry-delayed_job 98.91% <ø> (ø)
sentry-opentelemetry 100.00% <ø> (ø)
Files Coverage Δ
sentry-rails/lib/sentry/rails/active_job.rb 100.00% <100.00%> (ø)
sentry-rails/spec/sentry/rails/activejob_spec.rb 99.42% <ø> (-0.07%) ⬇️
sentry-ruby/lib/sentry/background_worker.rb 100.00% <100.00%> (ø)
sentry-ruby/lib/sentry/client.rb 100.00% <100.00%> (ø)
sentry-ruby/lib/sentry/configuration.rb 98.77% <ø> (-0.03%) ⬇️
sentry-ruby/lib/sentry/transport.rb 99.03% <100.00%> (-0.01%) ⬇️
sentry-ruby/spec/sentry/background_worker_spec.rb 100.00% <ø> (ø)
...ntry-ruby/spec/sentry/client/event_sending_spec.rb 99.50% <100.00%> (-0.13%) ⬇️
sentry-ruby/spec/sentry/configuration_spec.rb 100.00% <ø> (ø)
...try/transport/http_transport_rate_limiting_spec.rb 100.00% <100.00%> (ø)
... and 3 more

... and 1 file with indirect coverage changes

@getsantry
Copy link

getsantry bot commented Oct 18, 2023

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Oct 18, 2023
@sl0thentr0py sl0thentr0py changed the base branch from master to 6.0-dev April 26, 2024 11:23
@sl0thentr0py sl0thentr0py merged commit 7d86bb2 into 6.0-dev Apr 26, 2024
121 of 122 checks passed
@sl0thentr0py sl0thentr0py deleted the drop-async branch April 26, 2024 12:04
5.x automation moved this from In progress to Done Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
5.x
Done
Development

Successfully merging this pull request may close these issues.

async option will be dropped.
3 participants