-
-
Notifications
You must be signed in to change notification settings - Fork 519
Add request id to headers if exists #1033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
956330c
to
34fe550
Compare
Codecov Report
@@ Coverage Diff @@
## v3-1-stable #1033 +/- ##
==============================================
Coverage ? 98.15%
==============================================
Files ? 56
Lines ? 2443
Branches ? 0
==============================================
Hits ? 2398
Misses ? 45
Partials ? 0 Continue to review full report at Codecov.
|
34fe550
to
b974c22
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the PR 👍 just added some small suggestions
also, can you rebase this PR (or cherry-picking the commits) against v3-1-stable instead of master?
sorry I didn't make it clear but we currently only accept contributions to the 3.1.x
versions before the v4 is finished. (I have updated the readme & PR template for this though)
b974c22
to
e305965
Compare
No prob~~ done~ |
@berniechiu thanks for the work 👍 |
Description