Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable setting Cron monitor name #2290

Open
sethherr opened this issue Apr 5, 2024 · 0 comments
Open

Enable setting Cron monitor name #2290

sethherr opened this issue Apr 5, 2024 · 0 comments
Assignees

Comments

@sethherr
Copy link

sethherr commented Apr 5, 2024

Cron monitors created via Ruby use the slug as the name, and there isn't a way to programatically set the name.

There should be a way to set the name in sentry_monitor_check_ins via the monitor_config.

And ideally, the name should be the name of the class by default (rather than the slug)

Why do you think it's beneficial to most of the users

Slugs are much less readable, because they're only lower case, than the job name.

We've gone through and updated the Cron monitor names to be the job names in Sentry - but having to do that seems unreasonable.

Possible implementation

I don't know what the server API is like, but maybe this can just be added to the Sentry::Cron::MonitorCheckIns sentry_monitor_check_ins method?

def sentry_monitor_check_ins(slug: nil, monitor_config: nil)
  name = monitor_config&.dig(:name) || self.name

  if monitor_config && Sentry.configuration
    cron_config = Sentry.configuration.cron
    monitor_config.checkin_margin ||= cron_config.default_checkin_margin
    monitor_config.max_runtime ||= cron_config.default_max_runtime
    monitor_config.timezone ||= cron_config.default_timezone
  end

  @sentry_monitor_slug = slug
  @sentry_monitor_name = name
  @sentry_monitor_config = monitor_config

  prepend Patch
end
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

2 participants