Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cron monitors slug prefix #2279

Open
ixti opened this issue Mar 23, 2024 · 4 comments
Open

Cron monitors slug prefix #2279

ixti opened this issue Mar 23, 2024 · 4 comments
Assignees

Comments

@ixti
Copy link

ixti commented Mar 23, 2024

Cron monitor slugs are global per-organization. Thus, it will be very nice to be able to specify slugs prefix. In addition, it would be nice to keep sidekiq-scheduler's cron name as is instead of using slug as the name.

Why do you think it's beneficial to most of the users

  • Reduce possible slug collisions
  • Make UI more readable

Possible implementation

Sentry.init do |c|
  c.crons.slug_prefix = "myapp-"
end

Alternatively, if there will be a way to provide custom slugifier lambda - that will be enough. Either way it would be nice to keep original name as the monitor's name.

@sl0thentr0py
Copy link
Member

hey @ixti yea prefixes make sense, feel free to PR if you want it quicker otherwise I'll try to get to it sometime soon.

re: slug logic, the server decided to slugify anyway so it won't matter if we expose custom slugify logic on the SDK.

Sorry this is just a design choice we have to live with for now but I can pass on the feedback to our Crons team if they want to reconsider this.

@sethherr
Copy link

sethherr commented Apr 5, 2024

I agree that the name of the job should set the name of the monitor (rather than the slug). The slug is much less readable!

I opened #2290 specifically for setting the name.

@ixti
Copy link
Author

ixti commented Apr 5, 2024

re: slug logic, the server decided to slugify anyway so it won't matter if we expose custom slugify logic on the SDK.

If I read Python correctly, it only slugifies when slug is not presented

@evanpurkhiser
Copy link
Member

Sorry, a little late to the party here, but cron monitors are unique to the project now. We recently changed this: getsentry/sentry#66615

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

4 participants