Skip to content

Commit

Permalink
Bump faraday version to latest
Browse files Browse the repository at this point in the history
Bumping required faraday version to v1.0.0 from v0.7.6.
  • Loading branch information
ksylvest committed Jan 14, 2020
1 parent 065cf97 commit acaf182
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion sentry-raven.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,5 @@ Gem::Specification.new do |gem|
gem.bindir = "exe"
gem.executables = "raven"

gem.add_dependency "faraday", ">= 0.7.6", "< 1.0"
gem.add_dependency "faraday", ">= 1.0"
end
4 changes: 2 additions & 2 deletions spec/raven/integration_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -43,15 +43,15 @@
# end

it "timed backoff should prevent sends" do
expect(@instance.client.transport).to receive(:send_event).exactly(1).times.and_raise(Faraday::Error::ConnectionFailed, "conn failed")
expect(@instance.client.transport).to receive(:send_event).exactly(1).times.and_raise(Faraday::ConnectionFailed, "conn failed")
2.times { @instance.capture_exception(build_exception) }
expect(@io.string).to match(/Failed to submit event: ZeroDivisionError: divided by 0$/)
end

it "transport failure should call transport_failure_callback" do
@instance.configuration.transport_failure_callback = proc { |_e| @io.puts "OK!" }

expect(@instance.client.transport).to receive(:send_event).exactly(1).times.and_raise(Faraday::Error::ConnectionFailed, "conn failed")
expect(@instance.client.transport).to receive(:send_event).exactly(1).times.and_raise(Faraday::ConnectionFailed, "conn failed")
@instance.capture_exception(build_exception)
expect(@io.string).to match(/OK!$/)
end
Expand Down

0 comments on commit acaf182

Please sign in to comment.