Skip to content

Commit

Permalink
Pin JSON version to fix specs on ruby head
Browse files Browse the repository at this point in the history
The `JSON` 2.3.0 gem changed how parsing errors are raised. For example:

    require 'json'
    data = {}
    data['cycle'] = data
    JSON.dump(data)

With json v2.2.0:
This raises a `SystemStackError`.

With json v2.3.0:
This causes `fatal (machine stack overflow in critical region)`

Since the specs depend on 'SystemStackError' - pinning the version.
  • Loading branch information
ksylvest committed Jan 30, 2020
1 parent 2e4378d commit 03ec29c
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions .travis.yml
Expand Up @@ -14,6 +14,7 @@ rvm:
- 2.4.9
- 2.5.7
- 2.6.5
- 2.7.0

env:
- RAILS_VERSION=4
Expand Down
1 change: 1 addition & 0 deletions sentry-raven.gemspec
Expand Up @@ -18,4 +18,5 @@ Gem::Specification.new do |gem|
gem.executables = "raven"

gem.add_dependency "faraday", ">= 1.0"
gem.add_dependency "json", "<= 2.2.0"
end

0 comments on commit 03ec29c

Please sign in to comment.