Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect timeout warnings in AWS Lambda and GCP integrations #854

Merged
merged 6 commits into from Oct 14, 2020

Commits on Oct 12, 2020

  1. Changes:

    1) Added code to stop thread in aws_lambda.py & gcp.py.
    2) Modified logic of run() function of class TimeoutThread to stop the thread and raise ServerlessTimeoutWarning exception, conditionally.
    Shantanu Dhiman committed Oct 12, 2020
    Copy the full SHA
    d808d64 View commit details
    Browse the repository at this point in the history
  2. Changes:

    1) Improved the logic of run() function of class TimeoutThread to remove the dependency on time.sleep() method.
    Shantanu Dhiman committed Oct 12, 2020
    Copy the full SHA
    33eecb6 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2020

  1. Changes:

    1) Removed CPU consuming while loop from logic of run method of TimeoutThread class.
    2) Used Event class from threading module to send a stop signal for the thread.
    3) Changed cancel() to stop() for stopping thread  for AWS and GCP integration files.
    Shantanu Dhiman committed Oct 13, 2020
    Copy the full SHA
    1806fef View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2020

  1. Changes:

    1) Replaced time.sleep() method with wait() method so that the thread terminates before completing the full waiting time.
    Shantanu Dhiman committed Oct 14, 2020
    Copy the full SHA
    7e841a5 View commit details
    Browse the repository at this point in the history
  2. ref: reduce indentation

    rhcarvalho committed Oct 14, 2020
    Copy the full SHA
    80d79aa View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    59b32d4 View commit details
    Browse the repository at this point in the history