Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Auto enable integrations=true #845

Merged
merged 5 commits into from Oct 13, 2020
Merged

feat: Auto enable integrations=true #845

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f2e1eb1
feat: Auto enable integrations=true
HazAT Oct 2, 2020
e055b94
fix: Formatting
Oct 2, 2020
87b50fb
ref: Remove experiments flag
HazAT Oct 2, 2020
cdeda7a
Merge branch 'feat/auto-enable-integrations' of github.com:getsentry/…
HazAT Oct 2, 2020
baa7f1a
fix: Formatting
Oct 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion sentry_sdk/client.py
View file
Open in desktop
Expand Up @@ -128,7 +128,10 @@ def _send_sessions(sessions):
self.integrations = setup_integrations(
self.options["integrations"],
with_defaults=self.options["default_integrations"],
with_auto_enabling_integrations=self.options["_experiments"].get(
with_auto_enabling_integrations=self.options[
"auto_enabling_integrations"
]
or self.options["_experiments"].get(
"auto_enabling_integrations", False
),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's get rid of this flag, there is no backwards compat concern if auto enabling integrations are becoming the default

)
Expand Down
1 change: 1 addition & 0 deletions sentry_sdk/consts.py
View file
Open in desktop
Expand Up @@ -64,6 +64,7 @@ def __init__(
ca_certs=None, # type: Optional[str]
propagate_traces=True, # type: bool
traces_sample_rate=0.0, # type: float
auto_enabling_integrations=True, # type: bool
_experiments={}, # type: Experiments # noqa: B006
):
# type: (...) -> None
Expand Down