Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Do not attempt to access headers for all asgi requests #506

Merged
merged 2 commits into from Sep 20, 2019
Merged

fix: Do not attempt to access headers for all asgi requests #506

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6a97f6
fix: Do not attempt to access headers for all asgi requests
untitaker Sep 20, 2019
0e40cad
fix: Fix NameError
untitaker Sep 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 8 additions & 2 deletions sentry_sdk/integrations/asgi.py
View file
Open in desktop
Expand Up @@ -68,8 +68,14 @@ async def _run_app(self, scope, callback):
)
sentry_scope.add_event_processor(processor)

span = Span.continue_from_headers(dict(scope["headers"]))
span.op = "http.server"
if scope["type"] in ("http", "websocket"):
span = Span.continue_from_headers(dict(scope["headers"]))
span.op = "{}.server".format(scope["type"])
else:
span = Span()
span.op = "asgi.server"

span.set_tag("asgi.type", scope["type"])
span.transaction = "generic ASGI request"

with hub.start_span(span) as span:
Expand Down