feat(celery): Send Celery retry count #2971
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szokeasaurusrex
force-pushed
the
szokeasaurusrex/celery-retry-count
branch
from
4162d95
to
bbf6bd3
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/celery-retry-count
branch
from
bbf6bd3
to
57f1d44
Compare
szokeasaurusrex
changed the base branch from
sentry-sdk-2.0
to
szokeasaurusrex/celery-queue-consumer-default-exchange
szokeasaurusrex
force-pushed
the
szokeasaurusrex/celery-retry-count
branch
3 times, most recently
from
8a657d8
to
ef03803
Compare
szokeasaurusrex
commented
Apr 24, 2024
szokeasaurusrex
force-pushed
the
szokeasaurusrex/celery-queue-consumer-default-exchange
branch
from
8028917
to
5a99aad
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/celery-retry-count
branch
from
79d584d
to
57bd97e
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/celery-queue-consumer-default-exchange
branch
from
2fea931
to
3bf4c12
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/celery-retry-count
branch
from
edf4c0a
to
5baf5dd
Compare
antonpirker
approved these changes
Apr 30, 2024
szokeasaurusrex
force-pushed
the
szokeasaurusrex/celery-queue-consumer-default-exchange
branch
from
f1671f5
to
67e2531
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/celery-retry-count
branch
from
5baf5dd
to
73c11e8
Compare
This was referenced Apr 30, 2024
edwardgou-sentry
approved these changes
May 1, 2024
Add a test that ensures the retry count is set on the Celery task span. This test only tests a retry count of zero.
Add a test to verify that retry count gets set correctly, also for nonzero values.
szokeasaurusrex
force-pushed
the
szokeasaurusrex/celery-queue-consumer-default-exchange
branch
from
67e2531
to
e8ae74e
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/celery-retry-count
branch
from
42f3b19
to
6ed9bf7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #2984
ref #2959