New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add ray integration support (#2400) #2444
base: master
Are you sure you want to change the base?
Conversation
4ff38ec
to
9064e16
Compare
Is it planned to merge this PR? |
@leokster Taking a look now – likely this PR will require some changes before we can merge |
1e32127
to
44e3d24
Compare
The integration includes performance support. Also, add tests for the integration. Closes getsentry#2400
44e3d24
to
a2091db
Compare
@szokeasaurusrex you can do the review, I will adjust accordingly |
Might be interesting to review the PR for Langchain #2911 I am not familiar with Ray, but if it is a framework similar to Langchain, then following a similar model should be ideal cc @colin-sentry if you have any thoughts on this integration |
Hey @glowskir, thanks for reaching out again and for contributing this PR. We are currently working on an initiative to support AI tools in the Sentry SDK, and we would be interested in learning how you are using Ray and what you hope to be able to achieve by integrating Ray with Sentry. If you are interested, we can set up a customer call with you and anyone else interested in seeing a Ray integration in Sentry, so that we can learn how you are using Ray and how a Ray integration in the SDK could help you. You can reach me at daniel.szoke@sentry.io – please let me know when you would have time. |
@szokeasaurusrex This PR introduces RayIntegration to enable out of the box distributed tracing support. Ray has high level task interface and we want to see chain of tasks as single transaction in performance tab. At the moment of creating this PR there was no Opentelemetry support, now in newer versions of ray one can use Opentelemetry facitlities provided by Ray. I don't know how Sentry integrations relate to Opentelemetry hooks tbh, whether you are planning to adapt them or ignore them but this is a thing to consider. |
Closes #2400