Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): Github action checks failing #1780

Merged
merged 28 commits into from Dec 14, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
ddcf9a3
fix(ci): Github action checks failing
Zylphrex Dec 9, 2022
4076b54
bump
Zylphrex Dec 12, 2022
4906f43
run pytest as module
Zylphrex Dec 12, 2022
4aa4989
add comment explaining why
Zylphrex Dec 12, 2022
55a23ef
bump
Zylphrex Dec 12, 2022
2c0dafe
add comment to test-common
Zylphrex Dec 12, 2022
8790906
add reuse db
Zylphrex Dec 12, 2022
ad5eef5
lets see
Zylphrex Dec 12, 2022
ec3e3d0
what about this
Zylphrex Dec 12, 2022
ca14450
nope
Zylphrex Dec 12, 2022
d995ed4
verbose
Zylphrex Dec 12, 2022
ff3bad0
remove transaction=True
Zylphrex Dec 12, 2022
09d7423
Added one job to check if all tests have passed. Makes it easier to c…
antonpirker Dec 13, 2022
08325cf
One job to check if all required tests have passed.
antonpirker Dec 13, 2022
d0efe65
Updated check to work with pytest.
antonpirker Dec 13, 2022
1fc1d1d
debug output
antonpirker Dec 13, 2022
23eded4
debug output 2
antonpirker Dec 13, 2022
f7593c8
Updated config
antonpirker Dec 13, 2022
7c44d9e
Small fix
antonpirker Dec 13, 2022
61b7360
Updated config
antonpirker Dec 13, 2022
05faa7d
Continue on error on step level (to continue steps but mark the job a…
antonpirker Dec 13, 2022
c4d9609
Removed continue on error
antonpirker Dec 13, 2022
936f533
Cleanup
antonpirker Dec 13, 2022
be726af
Cleanup
antonpirker Dec 13, 2022
5f894b8
Always run all tests of a matric and do not cancel them when one envi…
antonpirker Dec 13, 2022
cb422fd
Updated conf
antonpirker Dec 13, 2022
797e73a
Trigger CI
antonpirker Dec 13, 2022
9263408
pin tox
Zylphrex Dec 13, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 6 additions & 5 deletions .github/workflows/test-common.yml
Expand Up @@ -24,7 +24,11 @@ jobs:
continue-on-error: true
strategy:
matrix:
os: [ubuntu-latest]
# python3.6 reached EOL and is no longer being supported on
# new versions of hosted runners on Github Actions
# ubuntu-20.04 is the last version that supported python3.6
# see https://github.com/actions/setup-python/issues/544#issuecomment-1332535877
os: [ubuntu-20.04]
python-version: ["2.7", "3.5", "3.6", "3.7", "3.8", "3.9", "3.10"]
services:
postgres:
Expand All @@ -51,9 +55,6 @@ jobs:
python-version: ${{ matrix.python-version }}

- name: Setup Test Env
env:
PGHOST: localhost
PGPASSWORD: sentry
run: |
pip install codecov tox

Expand All @@ -69,4 +70,4 @@ jobs:
./scripts/runtox.sh "py${{ matrix.python-version }}$" --cov=tests --cov=sentry_sdk --cov-report= --cov-branch --ignore=tests/integrations
coverage combine .coverage*
coverage xml -i
codecov --file coverage.xml
codecov --file coverage.xml
25 changes: 19 additions & 6 deletions .github/workflows/test-integration-aiohttp.yml
Expand Up @@ -27,12 +27,16 @@ jobs:
name: aiohttp, python ${{ matrix.python-version }}, ${{ matrix.os }}
runs-on: ${{ matrix.os }}
timeout-minutes: 45
continue-on-error: true

strategy:
fail-fast: false
matrix:
python-version: ["3.7","3.8","3.9","3.10"]
os: [ubuntu-latest]
# python3.6 reached EOL and is no longer being supported on
# new versions of hosted runners on Github Actions
# ubuntu-20.04 is the last version that supported python3.6
# see https://github.com/actions/setup-python/issues/544#issuecomment-1332535877
os: [ubuntu-20.04]

steps:
- uses: actions/checkout@v3
Expand All @@ -41,11 +45,8 @@ jobs:
python-version: ${{ matrix.python-version }}

- name: Setup Test Env
env:
PGHOST: localhost
PGPASSWORD: sentry
run: |
pip install codecov tox
pip install codecov "tox>=3,<4"

- name: Test aiohttp
env:
Expand All @@ -60,3 +61,15 @@ jobs:
coverage combine .coverage*
coverage xml -i
codecov --file coverage.xml

check_required_tests:
name: All aiohttp tests passed or skipped
needs: test
# Always run this, even if a dependent job failed
if: always()
runs-on: ubuntu-20.04
steps:
- name: Check for failures
if: contains(needs.test.result, 'failure')
run: |
echo "One of the dependent jobs have failed. You may need to re-run it." && exit 1
25 changes: 19 additions & 6 deletions .github/workflows/test-integration-asgi.yml
Expand Up @@ -27,12 +27,16 @@ jobs:
name: asgi, python ${{ matrix.python-version }}, ${{ matrix.os }}
runs-on: ${{ matrix.os }}
timeout-minutes: 45
continue-on-error: true

strategy:
fail-fast: false
matrix:
python-version: ["3.7","3.8","3.9","3.10"]
os: [ubuntu-latest]
# python3.6 reached EOL and is no longer being supported on
# new versions of hosted runners on Github Actions
# ubuntu-20.04 is the last version that supported python3.6
# see https://github.com/actions/setup-python/issues/544#issuecomment-1332535877
os: [ubuntu-20.04]

steps:
- uses: actions/checkout@v3
Expand All @@ -41,11 +45,8 @@ jobs:
python-version: ${{ matrix.python-version }}

- name: Setup Test Env
env:
PGHOST: localhost
PGPASSWORD: sentry
run: |
pip install codecov tox
pip install codecov "tox>=3,<4"

- name: Test asgi
env:
Expand All @@ -60,3 +61,15 @@ jobs:
coverage combine .coverage*
coverage xml -i
codecov --file coverage.xml

check_required_tests:
name: All asgi tests passed or skipped
needs: test
# Always run this, even if a dependent job failed
if: always()
runs-on: ubuntu-20.04
steps:
- name: Check for failures
if: contains(needs.test.result, 'failure')
run: |
echo "One of the dependent jobs have failed. You may need to re-run it." && exit 1
25 changes: 19 additions & 6 deletions .github/workflows/test-integration-aws_lambda.yml
Expand Up @@ -27,12 +27,16 @@ jobs:
name: aws_lambda, python ${{ matrix.python-version }}, ${{ matrix.os }}
runs-on: ${{ matrix.os }}
timeout-minutes: 45
continue-on-error: true

strategy:
fail-fast: false
matrix:
python-version: ["3.7"]
os: [ubuntu-latest]
# python3.6 reached EOL and is no longer being supported on
# new versions of hosted runners on Github Actions
# ubuntu-20.04 is the last version that supported python3.6
# see https://github.com/actions/setup-python/issues/544#issuecomment-1332535877
os: [ubuntu-20.04]

steps:
- uses: actions/checkout@v3
Expand All @@ -41,11 +45,8 @@ jobs:
python-version: ${{ matrix.python-version }}

- name: Setup Test Env
env:
PGHOST: localhost
PGPASSWORD: sentry
run: |
pip install codecov tox
pip install codecov "tox>=3,<4"

- name: Test aws_lambda
env:
Expand All @@ -60,3 +61,15 @@ jobs:
coverage combine .coverage*
coverage xml -i
codecov --file coverage.xml

check_required_tests:
name: All aws_lambda tests passed or skipped
needs: test
# Always run this, even if a dependent job failed
if: always()
runs-on: ubuntu-20.04
steps:
- name: Check for failures
if: contains(needs.test.result, 'failure')
run: |
echo "One of the dependent jobs have failed. You may need to re-run it." && exit 1
25 changes: 19 additions & 6 deletions .github/workflows/test-integration-beam.yml
Expand Up @@ -27,12 +27,16 @@ jobs:
name: beam, python ${{ matrix.python-version }}, ${{ matrix.os }}
runs-on: ${{ matrix.os }}
timeout-minutes: 45
continue-on-error: true

strategy:
fail-fast: false
matrix:
python-version: ["3.7"]
os: [ubuntu-latest]
# python3.6 reached EOL and is no longer being supported on
# new versions of hosted runners on Github Actions
# ubuntu-20.04 is the last version that supported python3.6
# see https://github.com/actions/setup-python/issues/544#issuecomment-1332535877
os: [ubuntu-20.04]

steps:
- uses: actions/checkout@v3
Expand All @@ -41,11 +45,8 @@ jobs:
python-version: ${{ matrix.python-version }}

- name: Setup Test Env
env:
PGHOST: localhost
PGPASSWORD: sentry
run: |
pip install codecov tox
pip install codecov "tox>=3,<4"

- name: Test beam
env:
Expand All @@ -60,3 +61,15 @@ jobs:
coverage combine .coverage*
coverage xml -i
codecov --file coverage.xml

check_required_tests:
name: All beam tests passed or skipped
needs: test
# Always run this, even if a dependent job failed
if: always()
runs-on: ubuntu-20.04
steps:
- name: Check for failures
if: contains(needs.test.result, 'failure')
run: |
echo "One of the dependent jobs have failed. You may need to re-run it." && exit 1
25 changes: 19 additions & 6 deletions .github/workflows/test-integration-boto3.yml
Expand Up @@ -27,12 +27,16 @@ jobs:
name: boto3, python ${{ matrix.python-version }}, ${{ matrix.os }}
runs-on: ${{ matrix.os }}
timeout-minutes: 45
continue-on-error: true

strategy:
fail-fast: false
matrix:
python-version: ["2.7","3.6","3.7","3.8"]
os: [ubuntu-latest]
# python3.6 reached EOL and is no longer being supported on
# new versions of hosted runners on Github Actions
# ubuntu-20.04 is the last version that supported python3.6
# see https://github.com/actions/setup-python/issues/544#issuecomment-1332535877
os: [ubuntu-20.04]

steps:
- uses: actions/checkout@v3
Expand All @@ -41,11 +45,8 @@ jobs:
python-version: ${{ matrix.python-version }}

- name: Setup Test Env
env:
PGHOST: localhost
PGPASSWORD: sentry
run: |
pip install codecov tox
pip install codecov "tox>=3,<4"

- name: Test boto3
env:
Expand All @@ -60,3 +61,15 @@ jobs:
coverage combine .coverage*
coverage xml -i
codecov --file coverage.xml

check_required_tests:
name: All boto3 tests passed or skipped
needs: test
# Always run this, even if a dependent job failed
if: always()
runs-on: ubuntu-20.04
steps:
- name: Check for failures
if: contains(needs.test.result, 'failure')
run: |
echo "One of the dependent jobs have failed. You may need to re-run it." && exit 1
25 changes: 19 additions & 6 deletions .github/workflows/test-integration-bottle.yml
Expand Up @@ -27,12 +27,16 @@ jobs:
name: bottle, python ${{ matrix.python-version }}, ${{ matrix.os }}
runs-on: ${{ matrix.os }}
timeout-minutes: 45
continue-on-error: true

strategy:
fail-fast: false
matrix:
python-version: ["2.7","3.5","3.6","3.7","3.8","3.9","3.10"]
os: [ubuntu-latest]
# python3.6 reached EOL and is no longer being supported on
# new versions of hosted runners on Github Actions
# ubuntu-20.04 is the last version that supported python3.6
# see https://github.com/actions/setup-python/issues/544#issuecomment-1332535877
os: [ubuntu-20.04]

steps:
- uses: actions/checkout@v3
Expand All @@ -41,11 +45,8 @@ jobs:
python-version: ${{ matrix.python-version }}

- name: Setup Test Env
env:
PGHOST: localhost
PGPASSWORD: sentry
run: |
pip install codecov tox
pip install codecov "tox>=3,<4"

- name: Test bottle
env:
Expand All @@ -60,3 +61,15 @@ jobs:
coverage combine .coverage*
coverage xml -i
codecov --file coverage.xml

check_required_tests:
name: All bottle tests passed or skipped
needs: test
# Always run this, even if a dependent job failed
if: always()
runs-on: ubuntu-20.04
steps:
- name: Check for failures
if: contains(needs.test.result, 'failure')
run: |
echo "One of the dependent jobs have failed. You may need to re-run it." && exit 1
25 changes: 19 additions & 6 deletions .github/workflows/test-integration-celery.yml
Expand Up @@ -27,12 +27,16 @@ jobs:
name: celery, python ${{ matrix.python-version }}, ${{ matrix.os }}
runs-on: ${{ matrix.os }}
timeout-minutes: 45
continue-on-error: true

strategy:
fail-fast: false
matrix:
python-version: ["2.7","3.5","3.6","3.7","3.8","3.9","3.10"]
os: [ubuntu-latest]
# python3.6 reached EOL and is no longer being supported on
# new versions of hosted runners on Github Actions
# ubuntu-20.04 is the last version that supported python3.6
# see https://github.com/actions/setup-python/issues/544#issuecomment-1332535877
os: [ubuntu-20.04]

steps:
- uses: actions/checkout@v3
Expand All @@ -41,11 +45,8 @@ jobs:
python-version: ${{ matrix.python-version }}

- name: Setup Test Env
env:
PGHOST: localhost
PGPASSWORD: sentry
run: |
pip install codecov tox
pip install codecov "tox>=3,<4"

- name: Test celery
env:
Expand All @@ -60,3 +61,15 @@ jobs:
coverage combine .coverage*
coverage xml -i
codecov --file coverage.xml

check_required_tests:
name: All celery tests passed or skipped
needs: test
# Always run this, even if a dependent job failed
if: always()
runs-on: ubuntu-20.04
steps:
- name: Check for failures
if: contains(needs.test.result, 'failure')
run: |
echo "One of the dependent jobs have failed. You may need to re-run it." && exit 1