Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic OpenTelemetry (OTel) Support #1692

Conversation

antonpirker
Copy link
Member

@antonpirker antonpirker commented Oct 19, 2022

Adding basic OpenTelementry (OTel) support to the Sentry SDK. This PR:

  • introduces a config option instrumenter where you can choose if peformance data should be collected by Sentry (when set to sentry) or should be collected by OpenTelementry (when set to otel)
  • adds a OTel SpanProcessor that can receive spans form OTel and then convert them into Sentry Spans and send them to Sentry.
  • adds a OTel Propagator that can receive and propagate trace headers (Baggage) to keep distributed tracing intact.
  • adds the possibility to set the start and end time of Sentry Spans (used to be only now())

Fixes #1687

@antonpirker antonpirker changed the title Added boilerplate for otel. Basic OpenTelemetry (oTel) Support Oct 19, 2022
@antonpirker antonpirker changed the title Basic OpenTelemetry (oTel) Support Basic OpenTelemetry (OTel) Support Nov 10, 2022
@vercel
Copy link

vercel bot commented Nov 10, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
sentry-python ✅ Ready (Inspect) Visit Preview Nov 17, 2022 at 2:02PM (UTC)

@antonpirker antonpirker marked this pull request as ready for review November 29, 2022 13:57
@sl0thentr0py
Copy link
Member

sl0thentr0py commented Nov 29, 2022

@antonpirker I would also recommend splitting this up into separate PRs (especially the API changes) for a clean history and better changelog.

see getsentry/sentry-ruby#1876 (comment)

@antonpirker antonpirker changed the base branch from master to antonpirker/1687-basic-otel-support-1-preparations November 30, 2022 12:25
@antonpirker
Copy link
Member Author

antonpirker commented Nov 30, 2022

@antonpirker
Copy link
Member Author

Closing this in favor of the split up PRs mentioned above.

@antonpirker antonpirker deleted the antonpirker/1687-basic-otel-support branch April 19, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Basic OpenTelemetry (OTEL) Support
2 participants