Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include framework in SDK name #1662

Merged
merged 10 commits into from
Oct 10, 2022

Conversation

antonpirker
Copy link
Member

@antonpirker antonpirker commented Oct 5, 2022

Currently the Python sdk reports always the name sentry.python as its name. For consistent sdk naming and better data analysis of events we want to have also include the framework in the SDK name. Like sentry.python.django.

Fixes #1497

@antonpirker antonpirker marked this pull request as ready for review October 5, 2022 13:03
sentry_sdk/client.py Show resolved Hide resolved
@antonpirker
Copy link
Member Author

I did not make the var lower case although it is no real const anymore but having it uppercase just shows me that it is defined somewhere on the top (and not given as a parameter)

sentry_sdk/consts.py Outdated Show resolved Hide resolved
@antonpirker antonpirker merged commit a48fafd into master Oct 10, 2022
@antonpirker antonpirker deleted the antonpirker/1497-sdk-name-with-framework branch October 10, 2022 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SDK Name should include framework used
3 participants