Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update session also for non sampled events and change filter order #1394

Merged
merged 6 commits into from Apr 20, 2022

Commits on Apr 14, 2022

  1. Update session also for non sampled events and change filter order

    We have already merged #1390 where we moved `ignore_errors` before sampling.
    
    Background for the order change:
    We want to update the session for dropped events in case the event is dropped by sampling. Events dropped by other mechanisms should not update the session. See getsentry/develop#551
    
    Now we would like to discuss if we can simply move sampling after `before_send` and `event_processor` and update the session right before sampling.
    What are implications of changing this?
    * How does this affect session count and session crash rate?
    * Will this have a negative effect on performance as `before_send` and `event_processor` will now be executed for every event instead of only being executed for sampled events? Developers may have fine tuned their sample rate for a good performance tradeoff and now we change. Also developers can supply their own implementations for both `before_send` and `event_processor` on some SDKs so we have no way of predicting performance I'm afraid.
    * We are uncertain why a developer chose to drop an event in `before_send` and `event_processor`:
    ** Was it because they want to ignore the event - then it shouldn't update the session
    ** Or was it to save quota - then it should update the session
    
    Please feel free to optimize the code this is just to start the discussion.
    adinauer committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    29692eb View commit details
    Browse the repository at this point in the history
  2. Update client.py

    adinauer committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    5edb634 View commit details
    Browse the repository at this point in the history
  3. Specify return type

    adinauer committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    a3bc972 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2022

  1. Configuration menu
    Copy the full SHA
    1c3e4d0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3b5fdef View commit details
    Browse the repository at this point in the history
  3. Learn how to commit

    sl0thentr0py committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    d4cb745 View commit details
    Browse the repository at this point in the history