Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Falcon integration to support Falcon 3.0.0 #1073

Closed
wants to merge 1 commit into from

Conversation

Seluj78
Copy link

@Seluj78 Seluj78 commented Apr 6, 2021

As discussed here: falconry/falcon#1898 (comment)

@vytas7
Copy link

vytas7 commented Apr 6, 2021

FWIW, the module in question was removed (renamed) by oversight: falconry/falcon#1902

@github-actions
Copy link

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@pecalleja
Copy link

any news about this?

@antonpirker
Copy link
Member

Hello @Seluj78 !
Thanks for your contribution!

We also got an PR for Falcon 3.0.1 from @bartolootrit:
#1297

Could you @Seluj78 talk to @bartolootrit on how you can merge the two PRs into one? So we have only one Falcon Integration that we can review and eventually merge?

Thanks!

@antonpirker antonpirker added enhancement New feature or request and removed Status: Backlog labels Feb 15, 2022
@antonpirker
Copy link
Member

Maybe also @pecalleja could help somehow?

@antonpirker antonpirker added Help wanted Extra attention is needed Integration: Falcon labels Feb 15, 2022
@pecalleja
Copy link

@antonpirker Yes, I would love to help !!! do you need help to test the solution
or
to review both PR and try to merge both in one?

@bartolootrit
Copy link
Contributor

bartolootrit commented Feb 15, 2022

@antonpirker, @Seluj78 If I open a pull request from bartolootrit:falcon-3-integration into Seluj78:patch-1, it will overwrite all changes in Seluj78:patch-1. What else can we do?

@Seluj78
Copy link
Author

Seluj78 commented Feb 16, 2022

What you can do is just create a new branch from master and copy manually the changes from the different PRs :)

@bartolootrit
Copy link
Contributor

What you can do is just create a new branch from master and copy manually the changes from the different PRs :)

A new PR after this process would be equal to #1297. If it's expected, then this PR might be closed, if not, what should I change in #1297?

@github-actions
Copy link

github-actions bot commented Mar 9, 2022

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@sl0thentr0py
Copy link
Member

@bartolootrit cool then let's just continue in #1297.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Help wanted Extra attention is needed Integration: Falcon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants