Skip to content

Commit

Permalink
fix(ci): Github action checks failing
Browse files Browse the repository at this point in the history
The checks are failing for 2 reasons

1. Github actions dropped python3.7 support on the latest hosted runners.
   actions/setup-python#544 (comment)
2. New release of tox was validation the python version in the environment name
   and the trailing framework version being used in the environment name was
   being treated as a python version and validated causing an issue.
  • Loading branch information
Zylphrex committed Dec 9, 2022
1 parent b1290c6 commit ddcf9a3
Show file tree
Hide file tree
Showing 30 changed files with 313 additions and 201 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/test-common.yml
Expand Up @@ -24,7 +24,7 @@ jobs:
continue-on-error: true
strategy:
matrix:
os: [ubuntu-latest]
os: [ubuntu-20.04]
python-version: ["2.7", "3.5", "3.6", "3.7", "3.8", "3.9", "3.10"]
services:
postgres:
Expand Down Expand Up @@ -69,4 +69,4 @@ jobs:
./scripts/runtox.sh "py${{ matrix.python-version }}$" --cov=tests --cov=sentry_sdk --cov-report= --cov-branch --ignore=tests/integrations
coverage combine .coverage*
coverage xml -i
codecov --file coverage.xml
codecov --file coverage.xml
6 changes: 5 additions & 1 deletion .github/workflows/test-integration-aiohttp.yml
Expand Up @@ -32,7 +32,11 @@ jobs:
strategy:
matrix:
python-version: ["3.7","3.8","3.9","3.10"]
os: [ubuntu-latest]
# python3.6 reached EOL and is no longer being supported on
# new versions of hosted runners on Github Actions
# ubuntu-20.04 is the last version that supported python3.6
# see https://github.com/actions/setup-python/issues/544#issuecomment-1332535877
os: [ubuntu-20.04]

steps:
- uses: actions/checkout@v3
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/test-integration-asgi.yml
Expand Up @@ -32,7 +32,11 @@ jobs:
strategy:
matrix:
python-version: ["3.7","3.8","3.9","3.10"]
os: [ubuntu-latest]
# python3.6 reached EOL and is no longer being supported on
# new versions of hosted runners on Github Actions
# ubuntu-20.04 is the last version that supported python3.6
# see https://github.com/actions/setup-python/issues/544#issuecomment-1332535877
os: [ubuntu-20.04]

steps:
- uses: actions/checkout@v3
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/test-integration-aws_lambda.yml
Expand Up @@ -32,7 +32,11 @@ jobs:
strategy:
matrix:
python-version: ["3.7"]
os: [ubuntu-latest]
# python3.6 reached EOL and is no longer being supported on
# new versions of hosted runners on Github Actions
# ubuntu-20.04 is the last version that supported python3.6
# see https://github.com/actions/setup-python/issues/544#issuecomment-1332535877
os: [ubuntu-20.04]

steps:
- uses: actions/checkout@v3
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/test-integration-beam.yml
Expand Up @@ -32,7 +32,11 @@ jobs:
strategy:
matrix:
python-version: ["3.7"]
os: [ubuntu-latest]
# python3.6 reached EOL and is no longer being supported on
# new versions of hosted runners on Github Actions
# ubuntu-20.04 is the last version that supported python3.6
# see https://github.com/actions/setup-python/issues/544#issuecomment-1332535877
os: [ubuntu-20.04]

steps:
- uses: actions/checkout@v3
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/test-integration-boto3.yml
Expand Up @@ -32,7 +32,11 @@ jobs:
strategy:
matrix:
python-version: ["2.7","3.6","3.7","3.8"]
os: [ubuntu-latest]
# python3.6 reached EOL and is no longer being supported on
# new versions of hosted runners on Github Actions
# ubuntu-20.04 is the last version that supported python3.6
# see https://github.com/actions/setup-python/issues/544#issuecomment-1332535877
os: [ubuntu-20.04]

steps:
- uses: actions/checkout@v3
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/test-integration-bottle.yml
Expand Up @@ -32,7 +32,11 @@ jobs:
strategy:
matrix:
python-version: ["2.7","3.5","3.6","3.7","3.8","3.9","3.10"]
os: [ubuntu-latest]
# python3.6 reached EOL and is no longer being supported on
# new versions of hosted runners on Github Actions
# ubuntu-20.04 is the last version that supported python3.6
# see https://github.com/actions/setup-python/issues/544#issuecomment-1332535877
os: [ubuntu-20.04]

steps:
- uses: actions/checkout@v3
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/test-integration-celery.yml
Expand Up @@ -32,7 +32,11 @@ jobs:
strategy:
matrix:
python-version: ["2.7","3.5","3.6","3.7","3.8","3.9","3.10"]
os: [ubuntu-latest]
# python3.6 reached EOL and is no longer being supported on
# new versions of hosted runners on Github Actions
# ubuntu-20.04 is the last version that supported python3.6
# see https://github.com/actions/setup-python/issues/544#issuecomment-1332535877
os: [ubuntu-20.04]

steps:
- uses: actions/checkout@v3
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/test-integration-chalice.yml
Expand Up @@ -32,7 +32,11 @@ jobs:
strategy:
matrix:
python-version: ["3.6","3.7","3.8"]
os: [ubuntu-latest]
# python3.6 reached EOL and is no longer being supported on
# new versions of hosted runners on Github Actions
# ubuntu-20.04 is the last version that supported python3.6
# see https://github.com/actions/setup-python/issues/544#issuecomment-1332535877
os: [ubuntu-20.04]

steps:
- uses: actions/checkout@v3
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/test-integration-django.yml
Expand Up @@ -32,7 +32,11 @@ jobs:
strategy:
matrix:
python-version: ["2.7","3.5","3.6","3.7","3.8","3.9","3.10"]
os: [ubuntu-latest]
# python3.6 reached EOL and is no longer being supported on
# new versions of hosted runners on Github Actions
# ubuntu-20.04 is the last version that supported python3.6
# see https://github.com/actions/setup-python/issues/544#issuecomment-1332535877
os: [ubuntu-20.04]
services:
postgres:
image: postgres
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/test-integration-falcon.yml
Expand Up @@ -32,7 +32,11 @@ jobs:
strategy:
matrix:
python-version: ["2.7","3.5","3.6","3.7","3.8","3.9","3.10"]
os: [ubuntu-latest]
# python3.6 reached EOL and is no longer being supported on
# new versions of hosted runners on Github Actions
# ubuntu-20.04 is the last version that supported python3.6
# see https://github.com/actions/setup-python/issues/544#issuecomment-1332535877
os: [ubuntu-20.04]

steps:
- uses: actions/checkout@v3
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/test-integration-fastapi.yml
Expand Up @@ -32,7 +32,11 @@ jobs:
strategy:
matrix:
python-version: ["3.7","3.8","3.9","3.10"]
os: [ubuntu-latest]
# python3.6 reached EOL and is no longer being supported on
# new versions of hosted runners on Github Actions
# ubuntu-20.04 is the last version that supported python3.6
# see https://github.com/actions/setup-python/issues/544#issuecomment-1332535877
os: [ubuntu-20.04]

steps:
- uses: actions/checkout@v3
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/test-integration-flask.yml
Expand Up @@ -32,7 +32,11 @@ jobs:
strategy:
matrix:
python-version: ["2.7","3.5","3.6","3.7","3.8","3.9","3.10"]
os: [ubuntu-latest]
# python3.6 reached EOL and is no longer being supported on
# new versions of hosted runners on Github Actions
# ubuntu-20.04 is the last version that supported python3.6
# see https://github.com/actions/setup-python/issues/544#issuecomment-1332535877
os: [ubuntu-20.04]

steps:
- uses: actions/checkout@v3
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/test-integration-gcp.yml
Expand Up @@ -32,7 +32,11 @@ jobs:
strategy:
matrix:
python-version: ["3.7"]
os: [ubuntu-latest]
# python3.6 reached EOL and is no longer being supported on
# new versions of hosted runners on Github Actions
# ubuntu-20.04 is the last version that supported python3.6
# see https://github.com/actions/setup-python/issues/544#issuecomment-1332535877
os: [ubuntu-20.04]

steps:
- uses: actions/checkout@v3
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/test-integration-httpx.yml
Expand Up @@ -32,7 +32,11 @@ jobs:
strategy:
matrix:
python-version: ["3.6","3.7","3.8","3.9","3.10"]
os: [ubuntu-latest]
# python3.6 reached EOL and is no longer being supported on
# new versions of hosted runners on Github Actions
# ubuntu-20.04 is the last version that supported python3.6
# see https://github.com/actions/setup-python/issues/544#issuecomment-1332535877
os: [ubuntu-20.04]

steps:
- uses: actions/checkout@v3
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/test-integration-pure_eval.yml
Expand Up @@ -32,7 +32,11 @@ jobs:
strategy:
matrix:
python-version: ["3.5","3.6","3.7","3.8","3.9","3.10"]
os: [ubuntu-latest]
# python3.6 reached EOL and is no longer being supported on
# new versions of hosted runners on Github Actions
# ubuntu-20.04 is the last version that supported python3.6
# see https://github.com/actions/setup-python/issues/544#issuecomment-1332535877
os: [ubuntu-20.04]

steps:
- uses: actions/checkout@v3
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/test-integration-pymongo.yml
Expand Up @@ -32,7 +32,11 @@ jobs:
strategy:
matrix:
python-version: ["2.7","3.6","3.7","3.8","3.9","3.10"]
os: [ubuntu-latest]
# python3.6 reached EOL and is no longer being supported on
# new versions of hosted runners on Github Actions
# ubuntu-20.04 is the last version that supported python3.6
# see https://github.com/actions/setup-python/issues/544#issuecomment-1332535877
os: [ubuntu-20.04]

steps:
- uses: actions/checkout@v3
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/test-integration-pyramid.yml
Expand Up @@ -32,7 +32,11 @@ jobs:
strategy:
matrix:
python-version: ["2.7","3.5","3.6","3.7","3.8","3.9","3.10"]
os: [ubuntu-latest]
# python3.6 reached EOL and is no longer being supported on
# new versions of hosted runners on Github Actions
# ubuntu-20.04 is the last version that supported python3.6
# see https://github.com/actions/setup-python/issues/544#issuecomment-1332535877
os: [ubuntu-20.04]

steps:
- uses: actions/checkout@v3
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/test-integration-quart.yml
Expand Up @@ -32,7 +32,11 @@ jobs:
strategy:
matrix:
python-version: ["3.7","3.8","3.9","3.10"]
os: [ubuntu-latest]
# python3.6 reached EOL and is no longer being supported on
# new versions of hosted runners on Github Actions
# ubuntu-20.04 is the last version that supported python3.6
# see https://github.com/actions/setup-python/issues/544#issuecomment-1332535877
os: [ubuntu-20.04]

steps:
- uses: actions/checkout@v3
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/test-integration-redis.yml
Expand Up @@ -32,7 +32,11 @@ jobs:
strategy:
matrix:
python-version: ["2.7","3.7","3.8","3.9"]
os: [ubuntu-latest]
# python3.6 reached EOL and is no longer being supported on
# new versions of hosted runners on Github Actions
# ubuntu-20.04 is the last version that supported python3.6
# see https://github.com/actions/setup-python/issues/544#issuecomment-1332535877
os: [ubuntu-20.04]

steps:
- uses: actions/checkout@v3
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/test-integration-rediscluster.yml
Expand Up @@ -32,7 +32,11 @@ jobs:
strategy:
matrix:
python-version: ["2.7","3.7","3.8","3.9"]
os: [ubuntu-latest]
# python3.6 reached EOL and is no longer being supported on
# new versions of hosted runners on Github Actions
# ubuntu-20.04 is the last version that supported python3.6
# see https://github.com/actions/setup-python/issues/544#issuecomment-1332535877
os: [ubuntu-20.04]

steps:
- uses: actions/checkout@v3
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/test-integration-requests.yml
Expand Up @@ -32,7 +32,11 @@ jobs:
strategy:
matrix:
python-version: ["2.7","3.8","3.9"]
os: [ubuntu-latest]
# python3.6 reached EOL and is no longer being supported on
# new versions of hosted runners on Github Actions
# ubuntu-20.04 is the last version that supported python3.6
# see https://github.com/actions/setup-python/issues/544#issuecomment-1332535877
os: [ubuntu-20.04]

steps:
- uses: actions/checkout@v3
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/test-integration-rq.yml
Expand Up @@ -32,7 +32,11 @@ jobs:
strategy:
matrix:
python-version: ["2.7","3.5","3.6","3.7","3.8","3.9","3.10"]
os: [ubuntu-latest]
# python3.6 reached EOL and is no longer being supported on
# new versions of hosted runners on Github Actions
# ubuntu-20.04 is the last version that supported python3.6
# see https://github.com/actions/setup-python/issues/544#issuecomment-1332535877
os: [ubuntu-20.04]

steps:
- uses: actions/checkout@v3
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/test-integration-sanic.yml
Expand Up @@ -32,7 +32,11 @@ jobs:
strategy:
matrix:
python-version: ["3.5","3.6","3.7","3.8","3.9","3.10"]
os: [ubuntu-latest]
# python3.6 reached EOL and is no longer being supported on
# new versions of hosted runners on Github Actions
# ubuntu-20.04 is the last version that supported python3.6
# see https://github.com/actions/setup-python/issues/544#issuecomment-1332535877
os: [ubuntu-20.04]

steps:
- uses: actions/checkout@v3
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/test-integration-sqlalchemy.yml
Expand Up @@ -32,7 +32,11 @@ jobs:
strategy:
matrix:
python-version: ["2.7","3.7","3.8","3.9","3.10"]
os: [ubuntu-latest]
# python3.6 reached EOL and is no longer being supported on
# new versions of hosted runners on Github Actions
# ubuntu-20.04 is the last version that supported python3.6
# see https://github.com/actions/setup-python/issues/544#issuecomment-1332535877
os: [ubuntu-20.04]

steps:
- uses: actions/checkout@v3
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/test-integration-starlette.yml
Expand Up @@ -32,7 +32,11 @@ jobs:
strategy:
matrix:
python-version: ["3.7","3.8","3.9","3.10"]
os: [ubuntu-latest]
# python3.6 reached EOL and is no longer being supported on
# new versions of hosted runners on Github Actions
# ubuntu-20.04 is the last version that supported python3.6
# see https://github.com/actions/setup-python/issues/544#issuecomment-1332535877
os: [ubuntu-20.04]

steps:
- uses: actions/checkout@v3
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/test-integration-tornado.yml
Expand Up @@ -32,7 +32,11 @@ jobs:
strategy:
matrix:
python-version: ["3.7","3.8","3.9","3.10"]
os: [ubuntu-latest]
# python3.6 reached EOL and is no longer being supported on
# new versions of hosted runners on Github Actions
# ubuntu-20.04 is the last version that supported python3.6
# see https://github.com/actions/setup-python/issues/544#issuecomment-1332535877
os: [ubuntu-20.04]

steps:
- uses: actions/checkout@v3
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/test-integration-trytond.yml
Expand Up @@ -32,7 +32,11 @@ jobs:
strategy:
matrix:
python-version: ["3.5","3.6","3.7","3.8","3.9","3.10"]
os: [ubuntu-latest]
# python3.6 reached EOL and is no longer being supported on
# new versions of hosted runners on Github Actions
# ubuntu-20.04 is the last version that supported python3.6
# see https://github.com/actions/setup-python/issues/544#issuecomment-1332535877
os: [ubuntu-20.04]

steps:
- uses: actions/checkout@v3
Expand Down
6 changes: 5 additions & 1 deletion scripts/split-tox-gh-actions/split-tox-gh-actions.py
Expand Up @@ -34,7 +34,11 @@
strategy:
matrix:
python-version: [{{ python-version }}]
os: [ubuntu-latest]
# python3.6 reached EOL and is no longer being supported on
# new versions of hosted runners on Github Actions
# ubuntu-20.04 is the last version that supported python3.6
# see https://github.com/actions/setup-python/issues/544#issuecomment-1332535877
os: [ubuntu-20.04]
"""


Expand Down

0 comments on commit ddcf9a3

Please sign in to comment.