Stop using deprecated assertAttribute* methods of PHPUnit #780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jean85
approved these changes
Feb 25, 2019
HazAT
approved these changes
Feb 25, 2019
|
If we need to fix the Travis builds triggers, we need to look at https://docs.travis-ci.com/user/pull-requests#double-builds-on-pull-requests |
|
I believe that the problem with Travis CI is that it's not running for draft PRs (new feature of GitHub), while AppVeyor does (for some reason, maybe different webhooks used) |
|
This makes sense 👍 mark it as reviewable @ste93cry? Or is it not done yet? |
|
It is not finished yet, there are some points to think about how not to use the deprecated PHPUnit methods but keep testing those cases. Since this does not block any release, I will leave it in draft until I find a way to complete it |
ste93cry
force-pushed
the
fix-phpunit-deprecated-methods-usage
branch
from
a866a80
to
e0ec205
Compare
Jean85
requested changes
Apr 6, 2020
ste93cry
force-pushed
the
fix-phpunit-deprecated-methods-usage
branch
from
e26e70c
to
63c36e1
Compare
ste93cry
force-pushed
the
fix-phpunit-deprecated-methods-usage
branch
from
63c36e1
to
1f2f430
Compare
Jean85
approved these changes
Apr 7, 2020
ste93cry
force-pushed
the
fix-phpunit-deprecated-methods-usage
branch
2 times, most recently
from
466f364
to
f17864e
Compare
ste93cry
force-pushed
the
fix-phpunit-deprecated-methods-usage
branch
from
f17864e
to
4bb6214
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPUnit is going to deprecate and drop the
assertAttribute*methods in sebastianbergmann/phpunit#3338 and we use them in a few tests. This PR aims at refactoring such tests in some other way so that we are ready for a future upgrade of version of our test framework