Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: span vs transaction guzzle #1099

Merged
merged 2 commits into from Sep 29, 2020
Merged

fix: span vs transaction guzzle #1099

merged 2 commits into from Sep 29, 2020

Conversation

HazAT
Copy link
Member

@HazAT HazAT commented Sep 29, 2020 •
edited

Counterpart to:

getsentry/sentry-laravel#387 (review)

This makes it that the Guzzle Spans will be added to the span on the scope vs. always the transaction.
It makes a nicer tree view.

Before:
image

After:
image

stayallive
stayallive approved these changes Sep 29, 2020
View reviewed changes
Copy link
Collaborator

@stayallive stayallive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! 💪

ste93cry
ste93cry requested changes Sep 29, 2020
View reviewed changes
Copy link
Collaborator

@ste93cry ste93cry left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is based on develop branch rather than master. Please fix it before going on with the merge

@ste93cry ste93cry added this to the 3.0 milestone Sep 29, 2020
@HazAT HazAT changed the base branch from master to develop September 29, 2020 09:55
@HazAT
Copy link
Member Author

HazAT commented Sep 29, 2020

thx @ste93cry

@HazAT HazAT force-pushed the fix/span-vs-transaction-guzzle branch from a281353 to deb7c01 Compare September 29, 2020 10:52
@HazAT HazAT changed the base branch from develop to master September 29, 2020 10:52
@ste93cry ste93cry merged commit 65030a1 into master Sep 29, 2020
@ste93cry ste93cry deleted the fix/span-vs-transaction-guzzle branch September 29, 2020 12:44
@Jean85 Jean85 mentioned this pull request Oct 1, 2020
Closed
@dependabot dependabot bot mentioned this pull request Mar 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stayallive stayallive stayallive approved these changes

@ste93cry ste93cry ste93cry approved these changes

Assignees
No one assigned
Labels
Type: Bug
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@HazAT @stayallive @ste93cry