docs: provide example for breadcrumb data property #951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #951 +/- ##
==========================================
- Coverage 82.70% 82.65% -0.05%
==========================================
Files 53 53
Lines 7376 7376
Branches 1186 1186
==========================================
- Hits 6100 6097 -3
- Misses 1168 1171 +3
Partials 108 108 |
Swatinem
approved these changes
Feb 15, 2024
supervacuus
deleted the
docs/provide_example_for_breadcrumb_data_property
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A conversation on Discord made clear, that we have no example of how to create
dataproperties in breadcrumbs using thevalueAPI in the Native SDK. This PR rectifies this by adding thedataproperties of anhttpbreadcrumb and asserts on the new data in the integration tests.