fix: provide correct dependencies for CMake client projects... #926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...that use a system provided breakpad (instead of our vendored fork). The problem [here](#877) was that people who introduce sentry-native via CMake `find_package()` will get insufficient dependencies which leads to configuration errors in the client CMake project. There are two aspects to this problem: * if the user builds sentry as a shared library it shouldn't be necessary to specify the dependencies. This can be fixed by defining `breakpad` as a `PRIVATE` dependency in that case. This should also be the fix for the Gentoo issue because it uses sentry as a shared library afaict. * if the user builds sentry as a static library, then we must stay with the `PUBLIC` dependency, but we also need to correctly search for breakpad, libcurl and pthread in the context of the client project.
supervacuus
requested review from
Swatinem,
markushi,
anonrig and
bitsandfoxes
anonrig
approved these changes
Dec 19, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #926 +/- ##
=======================================
Coverage 82.61% 82.61%
=======================================
Files 53 53
Lines 7376 7376
Branches 1186 1186
=======================================
Hits 6094 6094
Misses 1173 1173
Partials 109 109 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...which use a system-provided
breakpad(instead of our vendored fork).The problem here was that people who introduce sentry-native via CMake
find_package()will get insufficient dependencies, which leads to configuration errors in the client CMake project.There are two aspects to this problem:
breakpadas aPRIVATEdependency. This should also fix the Gentoo issue because it uses sentry as a shared library afaict.PUBLICdependency, but we also need to correctly search forbreakpad,libcurl, andpthreadin the context of the client project.Fixes #877.