Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Maintain client in crashpad state #910

Merged
merged 4 commits into from
Nov 28, 2023

Conversation

supervacuus
Copy link
Collaborator

This PR is related to this issue: #900 (comment).

The crashpad client is stateful (on macOS, it contains the send right to the exception port), and it might be a good idea to keep the client instance for the life cycle of the Native SDK. This also fixes part of the issue (terminating one crashpad_handler kills the other). I don't see any downside to this, although having a second client will almost always overwrite a previously initialized one.

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Merging #910 (7f98f9e) into master (9901c01) will increase coverage by 0.11%.
The diff coverage is 80.00%.

❗ Current head 7f98f9e differs from pull request most recent head f07b3e3. Consider uploading reports for the commit f07b3e3 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #910      +/-   ##
==========================================
+ Coverage   82.59%   82.71%   +0.11%     
==========================================
  Files          53       53              
  Lines        7372     7376       +4     
  Branches     1185     1185              
==========================================
+ Hits         6089     6101      +12     
+ Misses       1175     1167       -8     
  Partials      108      108              

Copy link
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@supervacuus supervacuus merged commit 671acff into master Nov 28, 2023
@supervacuus supervacuus deleted the fix/maintain_client_in_crashpad_state branch November 28, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants