Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update crashpad 2023 09 28 #891

Merged
merged 12 commits into from
Oct 2, 2023

Conversation

supervacuus
Copy link
Collaborator

@supervacuus supervacuus commented Sep 29, 2023

This will also fix: #882

But I am mostly trying to get a cross-check from the CI because I have some weird behavior when reinstalling the crashpad backend on Windows (this is not ready for review).

@supervacuus supervacuus marked this pull request as draft September 29, 2023 14:19
@codecov
Copy link

codecov bot commented Sep 30, 2023

Codecov Report

Merging #891 (5acae74) into master (d4f8268) will not change coverage.
The diff coverage is n/a.

❗ Current head 5acae74 differs from pull request most recent head 7a59089. Consider uploading reports for the commit 7a59089 to get more accurate results

@@           Coverage Diff           @@
##           master     #891   +/-   ##
=======================================
  Coverage   82.54%   82.54%           
=======================================
  Files          53       53           
  Lines        7366     7366           
  Branches     1185     1185           
=======================================
  Hits         6080     6080           
  Misses       1177     1177           
  Partials      109      109           

@supervacuus
Copy link
Collaborator Author

Okay, the failing LLVM-Mingw build is actually due to ninja being removed from the Windows runner image: actions/runner-images#8343

@supervacuus
Copy link
Collaborator Author

Okay, the failing LLVM-Mingw build is actually due to ninja being removed from the Windows runner image: actions/runner-images#8343

But the LLVM-Mingw build downloads and installs ninja in this PowerShell script: https://github.com/getsentry/sentry-native/blob/master/scripts/install-llvm-mingw.ps1#L33-L54

So, this build always used the installed ninja vs. the explicitly installed one.

@supervacuus supervacuus marked this pull request as ready for review October 2, 2023 09:54
@supervacuus supervacuus merged commit 4282e51 into master Oct 2, 2023
16 of 17 checks passed
@supervacuus supervacuus deleted the chore/update_crashpad_2023_09_28 branch October 2, 2023 11:10
@github-actions
Copy link

github-actions bot commented Oct 2, 2023

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- update crashpad 2023 09 28 ([#891](https://github.com/getsentry/sentry-native/pull/891))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 7a59089

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to compile crashpad due to missing <stdint.h> #includes (Linux) - fixed in upstream mini_chromium
2 participants