Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compiler error with msvc on non-unicode system #846

Merged
merged 1 commit into from
Jun 15, 2023

Conversation

xyz1001
Copy link
Contributor

@xyz1001 xyz1001 commented May 19, 2023

@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Merging #846 (0bdf456) into master (6c76f58) will decrease coverage by 0.08%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #846      +/-   ##
==========================================
- Coverage   82.60%   82.53%   -0.08%     
==========================================
  Files          53       53              
  Lines        7352     7362      +10     
  Branches     1185     1186       +1     
==========================================
+ Hits         6073     6076       +3     
- Misses       1170     1176       +6     
- Partials      109      110       +1     

Copy link
Collaborator

@supervacuus supervacuus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @xyz1001. The same applies here with global flags vs. setting via target_compile_options(). There is an upcoming refactoring I'll have to do for the MSVC build, and I will change that there. Please add a changelog entry in the following form:

**Fixes**:

- Fix MSVC compiler error with on non-Unicode systems ([#846](https://github.com/getsentry/sentry-native/pull/846), [crashpad#85](https://github.com/getsentry/crashpad/pull/85))

in the ## Unreleased section. Thx.

@supervacuus supervacuus merged commit 81572fe into getsentry:master Jun 15, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants