Fixes for mingw builds (+ ARM64) #794
Conversation
past-due
force-pushed
the
mingw_compile_fixes_1
branch
from
724f141
to
a60f542
Compare
past-due
changed the title
past-due
force-pushed
the
mingw_compile_fixes_1
branch
from
a60f542
to
a575276
Compare
| # if defined (NONAMELESSUNION) | ||
| stack_frame.AddrFrame.Offset = ctx.DUMMYUNIONNAME.DUMMYSTRUCTNAME.Fp; | ||
| # else | ||
| stack_frame.AddrFrame.Offset = ctx.Fp; | ||
| # endif |
There was a problem hiding this comment.
this looks weird, is that a mingw thing? Why is it only needed for Fp and not all the others?
There was a problem hiding this comment.
I probably should have added a comment on this - this is a Windows header thing (reference: with some details).
I have no particular insight into the why, but that’s how it is for this particular structure (reference: https://learn.microsoft.com/en-us/windows/win32/api/winnt/ns-winnt-arm64_nt_context). So this will match the headers, and work regardless of whether NONAMELESSUNION is defined.
past-due
force-pushed
the
mingw_compile_fixes_1
branch
from
a575276
to
8541a74
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #794 +/- ##
==========================================
+ Coverage 81.15% 81.24% +0.08%
==========================================
Files 53 53
Lines 6947 6936 -11
Branches 1112 1111 -1
==========================================
- Hits 5638 5635 -3
+ Misses 1198 1191 -7
+ Partials 111 110 -1 |
@supervacuus Done 👍 |
- Switch Crashpad transport on Linux to use libcurl ([#803](#803), [crashpad#75](getsentry/crashpad#75), [crashpad#79](getsentry/crashpad#79)) - Avoid accidentally mutating CONTEXT when client-side stack walking in Crashpad ([#803](#803), [crashpad#77](getsentry/crashpad#77)) - Fix various mingw compilation issues ([#794](#794), [crashpad#78](getsentry/crashpad#78)) - Updated Crashpad backend to 2023-02-07. ([#803](#803), [crashpad#80](getsentry/crashpad#80))
|
CC: @bitsandfoxes, @markushi |
This change helps fix mingw builds (together with: getsentry/crashpad#78)