fix: Iterate all debug directory entries #740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out a PE file can have more than one debug directory entry. We now iterate over all of them, trying to find the one that has a valid CodeView record that we can use to get a debug_id from.
kamilogorek
reviewed
Jul 29, 2022
| if (!debug_dict || debug_dict->Type != IMAGE_DEBUG_TYPE_CODEVIEW) { | ||
| size_t table_size = (size_t)debug_entry.Size; | ||
| size_t entry_size = sizeof(IMAGE_DEBUG_DIRECTORY); | ||
| if (table_size % entry_size != 0) { |
There was a problem hiding this comment.
Would it be possible to somehow iterate over some entries and just drop the one that was somehow malformed and has fewer bytes than necessary? Or is it not possible to tell which one would even be broken at this point?
There was a problem hiding this comment.
I think doing the same thing as crashpad here is okay. These structs have a fixed size, and the table should always be a multiple of that, otherwise the compiler did something wrong
kamilogorek
approved these changes
Jul 29, 2022
supervacuus
added a commit
that referenced
this pull request
Aug 1, 2022
supervacuus
added a commit
that referenced
this pull request
Aug 1, 2022
- bumps Linux CI host to Ubuntu 22.04 - bumps new gcc to 12, clang to 14 - bumps Android API/NDK to the latest versions (uses x86_64 images) - renames CI jobs, so their names are version-independent (for easier updating) - removes llvm apt repo - replaces codechecker "manual" build with snap package - update changelog with #740. Co-authored-by: Mischan Toosarani-Hausberger <mischan@abovevacant.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out a PE file can have more than one debug directory entry.
We now iterate over all of them, trying to find the one that has a valid
CodeView record that we can use to get a debug_id from.
Crashpad does the same here, for reference:
https://chromium.googlesource.com/crashpad/crashpad/+/refs/heads/main/snapshot/win/pe_image_reader.cc#162