Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(on_crash): follow-up to make on_crash releasable #734

Merged
merged 13 commits into from
Jul 27, 2022
Merged

ref(on_crash): follow-up to make on_crash releasable #734

merged 13 commits into from
Jul 27, 2022

Commits on Jul 16, 2022

  1. ref(on_crash): follow-up to make on_crash releasable 

    * mentioned in the header docs `before_send` vs `on_crash` behavior
* adapted `sentry__prepare_event` to provide a flag for backends on
  whether `before_send` should be invoked
* adapted backends to prevent running `before_send` even if `on_crash`
  returns true
* added `on_crash` vs `before_send` integration tests for `inproc` and
  `breakpad` (`crashpad` will follow)
* removed `stdbool.h` from `sentry.h` and replaced return value `bool`
  with `int` in `sentry_crash_function_t` (since bool seemed to be
  explicitly prevented in the header up to now)
* added remaining CHANGELOG entries for upcoming release
    @supervacuus
    supervacuus committed Jul 16, 2022
    Configuration menu
    Copy the full SHA
    982ad4d View commit details
    Browse the repository at this point in the history

  2. fix(ci): again a breaking update of virtual-environment 

    actions/runner-images#5835
    @supervacuus
    supervacuus committed Jul 16, 2022
    Configuration menu
    Copy the full SHA
    8fbc890 View commit details
    Browse the repository at this point in the history

  3. fix(ci): mark unused parameters in example callbacks

    @supervacuus
    supervacuus committed Jul 16, 2022
    Configuration menu
    Copy the full SHA
    2200a93 View commit details
    Browse the repository at this point in the history

  4. Add current PR to CHANGELOG

    @supervacuus
    supervacuus committed Jul 16, 2022
    Configuration menu
    Copy the full SHA
    a6ef7ec View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2022

  1. Add crashpad integration tests and fix immediate issues in backend.

    @supervacuus
    supervacuus committed Jul 17, 2022
    Configuration menu
    Copy the full SHA
    48609f8 View commit details
    Browse the repository at this point in the history

  2. Cleanup crashpad integration tests.

    @supervacuus
    supervacuus committed Jul 17, 2022
    Configuration menu
    Copy the full SHA
    21264e3 View commit details
    Browse the repository at this point in the history

  3. Enable crashpad integration tests on windows

    @supervacuus
    supervacuus committed Jul 17, 2022
    Configuration menu
    Copy the full SHA
    98fce5a View commit details
    Browse the repository at this point in the history

  4. Make sure _exit() is found on all Linux compilers.

    @supervacuus
    supervacuus committed Jul 17, 2022
    Configuration menu
    Copy the full SHA
    2a9b097 View commit details
    Browse the repository at this point in the history

  5. Make static checker happy again

    @supervacuus
    supervacuus committed Jul 17, 2022
    Configuration menu
    Copy the full SHA
    ae306a3 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2022

  1. Free event in inproc handler when on_crash hook discards it.

    @supervacuus
    supervacuus committed Jul 27, 2022
    Configuration menu
    Copy the full SHA
    7b9010c View commit details
    Browse the repository at this point in the history

  2. Adapt on_crash to use the before_send event pass-through

    @supervacuus
    supervacuus committed Jul 27, 2022
    Configuration menu
    Copy the full SHA
    3fc6160 View commit details
    Browse the repository at this point in the history

  3. Forgot to stage adapted example.c

    @supervacuus
    supervacuus committed Jul 27, 2022
    Configuration menu
    Copy the full SHA
    5c04de8 View commit details
    Browse the repository at this point in the history

  4. Update CONTRIBUTING.md with added example parameters.

    @supervacuus
    supervacuus committed Jul 27, 2022
    Configuration menu
    Copy the full SHA
    30064f5 View commit details
    Browse the repository at this point in the history