fix: retrieve only completed crash-reports from the crashpad database... #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when recovering the timestamp of the last potential crash on initialization.
Swatinem
approved these changes
May 30, 2022
|
Should we leave this for the time being or are you approving to merge this right away? |
|
We can as well merge it right away ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when recovering the timestamp of the last potential crash on initialization.
This is one attempt discussed with @Swatinem to fix #716. I create it as a draft though, because I still cannot reproduce the issue, but it still could be useful for testing if the customer has a stable repro.