Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Capture registers with inproc backend (FEEDBACK-1413) #714

Merged
merged 4 commits into from
Jun 14, 2022

Conversation

Swatinem
Copy link
Member

No description provided.

@Swatinem Swatinem requested a review from a team May 17, 2022 10:11
@supervacuus
Copy link
Collaborator

I tested this on my m1 mbp and added register writes via inline assembly right before the crash and could see most of the general-purpose registers survive into the disk dump of the event. I think you tested it on all OS+Arch combos I could provide besides that. But please let me know if further target-testing makes sense.

@Swatinem
Copy link
Member Author

I tested this only on x64 on all OSs. I would like to have someone give it a spin on 32/64-bit Android as well.

@supervacuus
Copy link
Collaborator

I can test Android only on the emulator and give aarch64 on Linux a try. But both probably not before Wednesday.

@supervacuus
Copy link
Collaborator

I tested this on aarch64 under Linux where it works correctly. I also tried to test this in android using the emulator. I can see that an aarch64 register dump is created in the sentry-native database path on the device, but I cannot really stress the register values for comparison because the crash-causing function is compiled using an armeabi-v7a toolchain. My insight into the android build setup is still lacking, but I will investigate further.

@supervacuus
Copy link
Collaborator

android aarch64 seems to work too. I cannot test armeabi-v7a, because the images provided for the emulator are too old. I do not own a device.

registers from the crashed JNI function

@Swatinem
Copy link
Member Author

Swatinem commented Jun 7, 2022

@supervacuus Thanks for the investigation! I think this is ready to land in that case.

@Swatinem Swatinem merged commit 2d53a5a into master Jun 14, 2022
@Swatinem Swatinem deleted the feat/inproc-regs branch June 14, 2022 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants