Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix not listening to queue events because QueueManager is registered as queue in the container and not by it's class name #568

Merged
merged 3 commits into from Sep 29, 2022
Merged

fix: Fix not listening to queue events because QueueManager is registered as queue in the container and not by it's class name #568

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
de5b5ce
fix doesn't send queue job transaction trace
cloudop Sep 8, 2022
95372fe
Add changelog entry
stayallive Sep 29, 2022
e0fdcc1
Merge branch 'master' into pullrequests/cloudop/master
stayallive Sep 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Expand Up @@ -2,6 +2,8 @@

## Unreleased

- Fix not listening to queue events because `QueueManager` is registered as `queue` in the container and not by it's class name (#568)

## 2.13.0

- Only catch `BindingResolutionException` when trying to get the PSR-7 request object from the container
Expand Down
4 changes: 2 additions & 2 deletions src/Sentry/Laravel/Tracing/ServiceProvider.php
View file
Open in desktop
Expand Up @@ -72,9 +72,9 @@ private function bindEvents(array $tracingConfig): void

$handler->subscribe();

if ($this->app->bound(QueueManager::class)) {
if ($this->app->bound('queue')) {
$handler->subscribeQueueEvents(
$this->app->make(QueueManager::class)
$this->app->make('queue')
);
}
}
Expand Down