Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tracing #387

Merged
merged 9 commits into from Sep 29, 2020
Merged

Improve tracing #387

merged 9 commits into from Sep 29, 2020

Conversation

stayallive
Copy link
Collaborator

@stayallive stayallive commented Sep 28, 2020

  • Nest view.render spans
  • Nest sql.query spans
  • Add 2 child spans to http.server
    • app.bootstrap the Laravel bootstrap process
    • app.handle (please suggest a better name) which will have all other spans that are generated by the user application as childs
  • Only boot the tracing provider if there was a hint of a DSN (like the Sentry SDK itself)
  • Move all tracing related events to it's own event handler

Current state:

image

@HazAT
Copy link
Member

HazAT commented Sep 29, 2020

Like the direction 👍

Copy link
Member

@HazAT HazAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool stuff, Changelog and we can release ^^

@stayallive stayallive marked this pull request as ready for review September 29, 2020 10:27
@stayallive stayallive merged commit 53886fa into master Sep 29, 2020
@stayallive stayallive deleted the feature/improve-tracing branch September 29, 2020 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants